Page MenuHomeSolus

Initial version of fdm-materials
ClosedPublic

Authored by kyrios123 on Jun 21 2018, 2:58 PM.

Details

Summary

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

Required to fix materials crash in cura. Reference task T6555.

Diff Detail

Repository
R4344 fdm-materials
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kyrios123 requested review of this revision.Jun 21 2018, 2:58 PM
kyrios123 created this revision.
kyrios123 retitled this revision from Initial version of fdm-materials, fixes T6555 to Initial version of fdm-materials.Jun 21 2018, 3:50 PM
kyrios123 edited the test plan for this revision. (Show Details)
kyrios123 updated this revision to Diff 7876.Jun 27 2018, 1:56 PM

drop comment

@sunnyflunk do mind if I land this ?

I am debating fdm-materials vs fdm_materials for the package name

I am debating fdm-materials vs fdm_materials for the package name

Ok, let me know what the conclusion is. Actually I put a - instead of a _ because I don't recall any package having a _ in its name.

sunnyflunk requested changes to this revision.Jul 18 2018, 10:29 AM

Lets update this to 3.4.1 (likely needs to be checked with all cura updates)

This revision now requires changes to proceed.Jul 18 2018, 10:29 AM
kyrios123 updated this revision to Diff 8207.Jul 18 2018, 10:53 AM

Bump to 3.4.1 to have the whole stack aligned

sunnyflunk accepted this revision.Jul 18 2018, 11:01 AM
This revision is now accepted and ready to land.Jul 18 2018, 11:01 AM
This revision was automatically updated to reflect the committed changes.