Page MenuHomeSolus

The inclusion of whalebird fixes T6303
AbandonedPublic

Authored by Devil505 on Jun 16 2018, 8:45 AM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T6303: Whalebird client
Test Plan

Application launched and works properly.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Devil505 created this revision.Jun 16 2018, 8:45 AM
Devil505 requested review of this revision.Jun 16 2018, 8:45 AM
JoshStrobl requested changes to this revision.Jun 20 2018, 4:48 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
13–40

You have a plethora of unnecessary builddeps here. Check each builddeps dependencies and reverse dependencies. You also didn't alphabetize this complete.

46

Should do yarn build:linux

This revision now requires changes to proceed.Jun 20 2018, 4:48 PM

Ping?

yarn build:linux doesn't work, it request snapcraft

package.yml
46

It doesn't work, it request snapcraft

JoshStrobl added inline comments.Jul 29 2018, 5:46 PM
package.yml
46

Alright in that case, need to still sort our your builddeps.

Devil505 marked 3 inline comments as done.Aug 14 2018, 12:04 PM

@JoshStrobl

I've tried to rebuild it with yarn and npm, I've got some errors on my side. Honestly I'm not a fan of electron stuff. Since there is tootle packaged now maybe whalebird is not needed ?

Moreover, I suppose the new SC will be able to provide the snap of whalebird https://snapcraft.io/whalebird

What do you think ?

I've tried to rebuild it with yarn and npm

As I stated in the comment, you only need to worry about the builddeps then.

Since there is tootle packaged now maybe whalebird is not needed ?

No but if you're not interested in resolving the issues, I'll abandoned this and unassign.

Moreover, I suppose the new SC will be able to provide the snap of whalebird

It's open source, it can be packaged. It's been accepted. I ? do ? not ? care ? if ? it ? has ? been ? snapped. Please stop suggesting snaps.

I'm not suggesting snaps, anyway, I'm giving up, you can close the task and this differential.

JoshStrobl abandoned this revision.Aug 22 2018, 4:45 AM