Page MenuHomeSolus

The inclusion of whalebird fixes T6303
AbandonedPublic

Authored by Devil505 on Jun 16 2018, 8:45 AM.
Tags
None
Referenced Files
F11022695: D3096.diff
Tue, Aug 8, 4:04 AM
F11004306: D3096.diff
Tue, Aug 1, 12:17 AM
F10987607: D3096.diff
Mon, Jul 24, 6:19 AM
F10864037: D3096.diff
Jun 17 2023, 5:39 AM
F10852272: D3096.id7692.diff
Jun 12 2023, 10:19 PM
F10841244: D3096.id7692.diff
Jun 10 2023, 6:02 AM
F10825503: D3096.diff
Jun 4 2023, 12:22 AM
F10776832: D3096.id.diff
May 23 2023, 4:34 PM
Subscribers

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T6303: Whalebird client
Test Plan

Application launched and works properly.

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
13–40

You have a plethora of unnecessary builddeps here. Check each builddeps dependencies and reverse dependencies. You also didn't alphabetize this complete.

46

Should do yarn build:linux

This revision now requires changes to proceed.Jun 20 2018, 4:48 PM

Ping?

yarn build:linux doesn't work, it request snapcraft

package.yml
46

It doesn't work, it request snapcraft

package.yml
46

Alright in that case, need to still sort our your builddeps.

@JoshStrobl

I've tried to rebuild it with yarn and npm, I've got some errors on my side. Honestly I'm not a fan of electron stuff. Since there is tootle packaged now maybe whalebird is not needed ?

Moreover, I suppose the new SC will be able to provide the snap of whalebird https://snapcraft.io/whalebird

What do you think ?

I've tried to rebuild it with yarn and npm

As I stated in the comment, you only need to worry about the builddeps then.

Since there is tootle packaged now maybe whalebird is not needed ?

No but if you're not interested in resolving the issues, I'll abandoned this and unassign.

Moreover, I suppose the new SC will be able to provide the snap of whalebird

It's open source, it can be packaged. It's been accepted. I ? do ? not ? care ? if ? it ? has ? been ? snapped. Please stop suggesting snaps.

I'm not suggesting snaps, anyway, I'm giving up, you can close the task and this differential.