Page MenuHomeSolus

Initial inclusion of budgie-shutdown-timer
ClosedPublic

Authored by Devil505 on Jun 15 2018, 12:31 PM.

Details

Summary

Initial inclusion of budgie-shutdown-timer. Resolves T5040.

Test Plan

Applet tested with budgie desktop.
Applet appears on panel.
Shutdown timer planned and working.

Diff Detail

Repository
R4335 budgie-shutdown-timer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Devil505 created this revision.Jun 15 2018, 12:31 PM
Devil505 requested review of this revision.Jun 15 2018, 12:31 PM
JoshStrobl requested changes to this revision.Jun 20 2018, 4:43 PM
JoshStrobl retitled this revision from The inclusion of budgie-shutdown-timer fixes T5040 to Initial inclusion of budgie-shutdown-timer.
JoshStrobl edited the summary of this revision. (Show Details)
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
7

It's GPL-3.0-or-later, not 3

8

Except this isn't the description of the applet at all.

14–15

Except this isn't the description of the applet at all. Also needs to be moved underneath summary.

This revision now requires changes to proceed.Jun 20 2018, 4:45 PM
Devil505 updated this revision to Diff 7765.Jun 20 2018, 5:03 PM

fixing errors

JoshStrobl requested changes to this revision.Jun 21 2018, 5:38 PM
JoshStrobl added inline comments.
package.yml
14–15

Still didn't move this up.

This revision now requires changes to proceed.Jun 21 2018, 5:38 PM
Devil505 updated this revision to Diff 7792.Jun 22 2018, 6:57 AM
Devil505 marked 3 inline comments as done.

moving up description part

JoshStrobl requested changes to this revision.Jun 25 2018, 8:19 PM
JoshStrobl added inline comments.
package.yml
16

Unnecessary whitespace otherwise LGTM

This revision now requires changes to proceed.Jun 25 2018, 8:19 PM
Devil505 updated this revision to Diff 7970.Jul 2 2018, 12:11 PM
Devil505 marked an inline comment as done.

fixing unnecessary whitespace

JoshStrobl accepted this revision.Jul 11 2018, 9:14 PM
This revision is now accepted and ready to land.Jul 11 2018, 9:14 PM
This revision was automatically updated to reflect the committed changes.