package.yml
6	Why using git (and not even a tag) rather than release tarball?
7	license needs to be SPDX-3.0 compatible: https://spdx.org/licenses/ Authors own packaging files indicates that it is meant to be `GPL-3.0-or-later` https://github.com/bleakgrey/tootle/blob/master/debian/copyright
10	Description should retain the format in its generated yml. i.e. description: \| Description on this line Also while a description isn't always obvious, you can borrow a line from the metainfo https://github.com/bleakgrey/tootle/blob/master/data/com.github.bleakgrey.tootle.appdata.xml.in#L12
13	`glib-2.0` isn't needed as implied by other deps
18	`meson` and `ninja` are part of system image, so don't need to be specified.
21	`--prefix` is unneeded and already specified via `%meson_configure` https://github.com/solus-project/ypkg/blob/master/ypkg2/rc.yml#L29
22	Lets keep the build step separate: build : \| %ninja_build
pspec_x86_64.xml
45	Need to use your actual name.

This revision now requires changes to proceed.Jun 6 2018, 5:25 AM

Address requested changes.

Put my real name on it (why tho)
Fix license
Add better description
Use .tar.gz instead of git commit
Remove implied dependencies
Add build step
Remove --prefix from configure step

What's a test plan

Marked finished items as "done" (I hope this is the way to do that)

Thanks for the fixes.

Note that when you first create the diff with arc diff it comes pre-formatted like this:

Screenshot_20180607_090230.png (530×866 px, 37 KB)

This is the place for the Test Plan, where you put how it's been tested, i.e. installing and using it's features (which will be different for each package)

This revision is now accepted and ready to land.Jun 6 2018, 11:25 PM

Closed by commit R4306:f81e58658e16: Create working build of tootle (authored by asonix, committed by • sunnyflunk). · Explain WhyJun 6 2018, 11:26 PM

This revision was automatically updated to reflect the committed changes.