Page MenuHomeSolus

Create working build of tootle
ClosedPublic

Authored by asonix on Jun 6 2018, 4:45 AM.

Details

Summary

This commit sees the creation of the package.yml file
for tootle, a GTK+ mastodon client written in Vala.

I'm not entirely sure what a test plan is, but I'm
currently running the package I built with this patch
and it works on my machine (tm)

Closes T6487

Diff Detail

Repository
R4306 tootle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

asonix created this revision.Jun 6 2018, 4:45 AM
asonix requested review of this revision.Jun 6 2018, 4:45 AM
sunnyflunk requested changes to this revision.Jun 6 2018, 5:25 AM
sunnyflunk added a subscriber: sunnyflunk.

Also needs a test plan

package.yml
6

Why using git (and not even a tag) rather than release tarball?

7

license needs to be SPDX-3.0 compatible: https://spdx.org/licenses/

Authors own packaging files indicates that it is meant to be GPL-3.0-or-later https://github.com/bleakgrey/tootle/blob/master/debian/copyright

10

Description should retain the format in its generated yml. i.e.

description: |
    Description on this line

Also while a description isn't always obvious, you can borrow a line from the metainfo https://github.com/bleakgrey/tootle/blob/master/data/com.github.bleakgrey.tootle.appdata.xml.in#L12

13

glib-2.0 isn't needed as implied by other deps

18

meson and ninja are part of system image, so don't need to be specified.

21

--prefix is unneeded and already specified via %meson_configure https://github.com/solus-project/ypkg/blob/master/ypkg2/rc.yml#L29

22

Lets keep the build step separate:

build      : |
    %ninja_build
pspec_x86_64.xml
45

Need to use your actual name.

This revision now requires changes to proceed.Jun 6 2018, 5:25 AM
asonix updated this revision to Diff 7524.Jun 6 2018, 10:44 PM

Address requested changes.

  • Put my real name on it (why tho)
  • Fix license
  • Add better description
  • Use .tar.gz instead of git commit
  • Remove implied dependencies
  • Add build step
  • Remove --prefix from configure step
asonix updated this revision to Diff 7525.Jun 6 2018, 10:46 PM
asonix edited the summary of this revision. (Show Details)

What's a test plan

asonix marked 8 inline comments as done.Jun 6 2018, 10:48 PM

Marked finished items as "done" (I hope this is the way to do that)

sunnyflunk accepted this revision.Jun 6 2018, 11:25 PM

Thanks for the fixes.

Note that when you first create the diff with arc diff it comes pre-formatted like this:

This is the place for the Test Plan, where you put how it's been tested, i.e. installing and using it's features (which will be different for each package)

This revision is now accepted and ready to land.Jun 6 2018, 11:25 PM
This revision was automatically updated to reflect the committed changes.