Page MenuHomeSolus

Inclusion of python-inflection, needed for mycroft-core (T4276)
ClosedPublic

Authored by clivejo on Jun 4 2018, 10:56 PM.

Details

Summary

The initial inclusion of python-inflection, one of the build deps for mycroft-core (T4276)

Diff Detail

Repository
R4307 python-inflection
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

clivejo created this revision.Jun 4 2018, 10:56 PM
clivejo requested review of this revision.Jun 4 2018, 10:56 PM
JoshStrobl requested changes to this revision.Jun 5 2018, 12:53 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
2

We typically just call it python-x even if it's only python3

This revision now requires changes to proceed.Jun 5 2018, 12:53 PM
clivejo updated this revision to Diff 7506.Jun 5 2018, 1:13 PM

Change package name as per review

clivejo retitled this revision from Inclusion of python3-inflection, needed for mycroft-core (T4276) to Inclusion of python-inflection, needed for mycroft-core (T4276).Jun 5 2018, 3:37 PM
clivejo edited the summary of this revision. (Show Details)
DataDrake accepted this revision.Jun 9 2018, 2:37 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Jun 9 2018, 2:40 PM
This revision was automatically updated to reflect the committed changes.