Page MenuHomeSolus

Update Riot to 0.15.3
ClosedPublic

Authored by silke on May 22 2018, 11:30 AM.
Tags
None
Referenced Files
F11053638: D2979.id7493.diff
Thu, Aug 10, 11:39 PM
F11053636: D2979.id7366.diff
Thu, Aug 10, 11:39 PM
F11053635: D2979.id.diff
Thu, Aug 10, 11:39 PM
F11053634: D2979.id7449.diff
Thu, Aug 10, 11:39 PM
F11037919: D2979.diff
Wed, Aug 9, 9:28 PM
F10988632: D2979.id7449.diff
Mon, Jul 24, 11:43 AM
F10876179: D2979.id7366.diff
Jun 20 2023, 9:27 AM
F10840861: D2979.id7366.diff
Jun 10 2023, 3:30 AM
Subscribers
None

Details

Summary
Test Plan

Install the application, send and receive few messages in a group chat

Diff Detail

Repository
R2816 element
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Hey just discovered this package because of this change. Before installing the SC states 'Node.js' needs to be installed however Node.js is bundled with Electron right? Don't think`nodejs` should be a listed dependency.

@Siilwyn: no, Electron does not necessarily come bundled with Node.JS (it is a framework after all). Electron does depend on Node.JS, and is a dependency of Riot because Electron is bundled with the application.

@silke aha, thank you for your reply! I looked into the building step, most Electron apps package with for example https://github.com/electron-userland/electron-packager which Riot doesn't that's why. I don't want to install Node.js as a dependency as it might conflict with my Node.js version manager... Not sure though, either way I'll just stick with the website for now.

This revision is now accepted and ready to land.Jun 4 2018, 3:41 PM
This revision was automatically updated to reflect the committed changes.