Page MenuHomeSolus

Added support for gtk2 along side with gtk3
ClosedPublic

Authored by ZachBacon on Jun 1 2017, 11:04 AM.

Details

Summary

Included support for gtk2 along with gtk3

Test Plan

Make sure gtk2 app menu's are exported along with gtk3 app menu's and make sure the static libs are stripped.

Diff Detail

Repository
R3084 unity-gtk-module
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ZachBacon created this revision.Jun 1 2017, 11:04 AM
ikey requested changes to this revision.Jun 2 2017, 8:58 PM
ikey added a subscriber: ikey.
ikey added inline comments.
package.yml
19

Need to restore --disable-static on both invocations please :)

This revision now requires changes to proceed.Jun 2 2017, 8:58 PM
ZachBacon updated this revision to Diff 669.Jun 3 2017, 8:49 PM
ZachBacon edited edge metadata.
ZachBacon edited the test plan for this revision. (Show Details)
  • disable static libs from being made
  • Package rel and bumping
ikey accepted this revision.Jul 20 2017, 2:46 PM
This revision is now accepted and ready to land.Jul 20 2017, 2:46 PM
This revision was automatically updated to reflect the committed changes.