Page MenuHomeSolus

Update geoclue to 2.4.10
AbandonedPublic

Authored by kyrios123 on May 14 2018, 7:40 PM.
Tags
  • Restricted Project
Referenced Files
F11055106: D2935.id.diff
Fri, Aug 11, 1:27 AM
F11055104: D2935.id7187.diff
Fri, Aug 11, 1:27 AM
F11038421: D2935.diff
Wed, Aug 9, 10:40 PM
F11029897: D2935.diff
Wed, Aug 9, 10:08 AM
F11016271: D2935.diff
Sat, Aug 5, 5:23 PM
F10986084: D2935.id7187.diff
Sun, Jul 23, 11:48 PM
F10962715: D2935.diff
Tue, Jul 18, 11:32 PM
F10962332: D2935.diff
Tue, Jul 18, 9:16 PM
Subscribers

Details

Reviewers
None
Group Reviewers
Triage Team
Summary
  • Use systemd's service file to lockdown the geoclue daemon to stop eventual security problems.
  • Modem GPS refresh rate is now based on the location refresh rate of apps.
  • Refuse location access if no app-auth agent is registered. This fixes a security hole where an app requests location access before the agent gets to register itself and we end up giving out locaiton access even though user has disabled it.
  • Port desktop ID detection to Flatpak >= 0.6.10.
  • The default timeout on the service binary is now the same as the service itself: 5 seconds.
  • Demo applications:
    • where-am-i now allows setting location refresh-rate.
    • Only install demo agent's desktop file if it's enabled.
    • Build and install demo agent unless disabled explicitly.
    • Autostart the demo agent by default on non-GNOME platforms, since an agent is required now and no one other than GNOME yet provides one (sigh).

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

Tested with redshift after enabling the Location Services in Settings -> Privacy

Diff Detail

Repository
R891 geoclue
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

  1. I did modify some paths to gets things out of /etc and to move the systemd services under /usr/lib64. Is it better like this ?
  2. Do we want the demo agent ? I noticed that indeed with the previous version, the autostart .desktop file was installed but not the agent
  3. Wouldn't it be better to run the dbus service with a dedicated user instead of root ?
JoshStrobl added a subscriber: JoshStrobl.

Marking as abandoned. As you know from my PM, there is work I need to do on the Budgie-front (implementing a geoclue agent) in order to facilitate this, as the demo agent is not something I'd ideally like to rely on. Naturally once that agent is implemented in Budgie, an upgrade to the latest geoclue will occur. Thank you for the patch.