Paths

Table of Contentst

Differential D2907

Initial inclusion of lua-filesystem
AbandonedPublic
Actions

Authored by mn on May 11 2018, 8:02 PM.

Tags

None

Referenced Files

	F11004447: D2907.diff
	Tue, Aug 1, 1:34 AM

	F10993171: D2907.diff
	Tue, Jul 25, 3:59 PM

	F10955435: D2907.diff
	Mon, Jul 17, 7:17 AM

	F10864114: D2907.diff
	Jun 17 2023, 6:31 AM

	F10790904: D2907.diff
	May 27 2023, 1:00 AM

	F10790732: D2907.diff
	May 27 2023, 12:21 AM

	F10754579: D2907.id7142.diff
	May 16 2023, 9:07 PM

	F10753842: D2907.diff
	May 16 2023, 7:07 PM

View All 14 Files

Subscribers

Details

Reviewers

Group Reviewers

Summary

Initial inclusion of LuaFileSystem libary (T5351). Built against lua5.3, the standard lua runtime

Test Plan

Ran the LuaFileSystem test suite (source-tarball/tests/test.lua)

Diff Detail

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

mn created this revision.May 11 2018, 8:02 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptMay 11 2018, 8:02 PM

mn requested review of this revision.May 11 2018, 8:02 PM

mn mentioned this in T5351: LuaFileSystem.May 11 2018, 8:10 PM

JoshStrobl requested changes to this revision.May 18 2018, 4:18 PM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
6–7	Should just be `license : MIT`
11	This should be 4 spaces not 2. You used our `package.yml` generator, right? https://solus-project.com/articles/packaging/packaging-practices/en/#generating-a-package-yml
13	You should be using `pkgconfig(lua)` as per https://solus-project.com/articles/packaging/packaging-practices/en/#using-pkgconfig-dependencies

This revision now requires changes to proceed.May 18 2018, 4:18 PM

JoshStrobl retitled this revision from Package build info for lua-filesystem 1.7.0.2 to Initial inclusion of lua-filesystem.May 18 2018, 4:18 PM

JoshStrobl edited the summary of this revision. (Show Details)

JoshStrobl mentioned this in D2908: Initial inclusion of lua51-filesystem.

Closing due to lack of response.

Revision Contents
Changeset List

Path

Size

1 line

1 line

21 lines

pspec_x86_64.xml

34 lines

Diff 7142

Makefile

Loading...

abi_used_libs

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...