Page MenuHomeSolus

Fix vcut segfault with patch Resolves T6292
ClosedPublic

Authored by Schteve on May 2 2018, 7:32 PM.
Tags
None
Referenced Files
F11053887: D2838.id6950.diff
Fri, Aug 11, 12:11 AM
F11053886: D2838.id6969.diff
Fri, Aug 11, 12:11 AM
F11053885: D2838.id.diff
Fri, Aug 11, 12:11 AM
F11037990: D2838.diff
Wed, Aug 9, 9:47 PM
F10995990: D2838.diff
Wed, Jul 26, 9:00 AM
F10935044: D2838.id.diff
Jul 12 2023, 5:49 PM
F10881981: D2838.id.diff
Jun 23 2023, 7:24 AM
F10750735: D2838.id6950.diff
May 16 2023, 9:10 AM
Subscribers

Details

Summary

Signed-off-by: Steven Moseley <stevenmos@kolabnow.com>

Test Plan

Attempt to cut a .ogg file was successful

Diff Detail

Repository
R3146 vorbis-tools
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

To clarify the test plan, doing the exact same step (but without the patch added) led to a segfault? Naturally we need to make sure it was a segfault case that now works to validate the fix.

Sorry, I didn't mean to be unclear.

When I do $ vcut i.ogg o1.ogg o2.ogg +1 with the unpatched vcut/vorbis-tools I get:

Processing: Cutting at 1.000000 seconds
Segmentation fault

and this from dmsg

$ dmsg | tail
`[ 1159.205956] vcut[2436]: segfault at 7ffc1bcc40c5 ip 00007fcbdce02451 sp 00007ffc1a3b0bd8 error 4 in libc-2.26.so[7fcbdcd4e000+1db000]

whereas with the patch it works as expected.

This revision is now accepted and ready to land.May 3 2018, 10:48 AM
This revision was automatically updated to reflect the committed changes.