Signed-off-by: Steven Moseley <stevenmos@kolabnow.com>
Details
Details
- Reviewers
• sunnyflunk - Group Reviewers
Triage Team - Commits
- R3146:fb2b7eb1f68c: Fix vcut segfault with patch
Attempt to cut a .ogg file was successful
Diff Detail
Diff Detail
- Repository
- R3146 vorbis-tools
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
To clarify the test plan, doing the exact same step (but without the patch added) led to a segfault? Naturally we need to make sure it was a segfault case that now works to validate the fix.
Comment Actions
Sorry, I didn't mean to be unclear.
When I do $ vcut i.ogg o1.ogg o2.ogg +1 with the unpatched vcut/vorbis-tools I get:
Processing: Cutting at 1.000000 seconds Segmentation fault
and this from dmsg
$ dmsg | tail `[ 1159.205956] vcut[2436]: segfault at 7ffc1bcc40c5 ip 00007fcbdce02451 sp 00007ffc1a3b0bd8 error 4 in libc-2.26.so[7fcbdcd4e000+1db000]
whereas with the patch it works as expected.