Page MenuHomeSolus

Update gajim to Version 1.0.2
ClosedPublic

Authored by cigh033 on May 2 2018, 6:53 PM.

Details

Summary

Update gajim to version 1.0.2 (now with GTK3/Python3)

this depends on D2836

biggest changes since 0.16.9:

  • Ported to GTK3 / Python3
  • Integrate HTTPUpload
  • Improvements for HiDPI Screens
  • Change password storage to python keyring package

Full Changelog can be found here https://dev.gajim.org/gajim/gajim/blob/gajim-1.0.2/ChangeLog

Test Plan

Installed, launched, added account and installed plugin

Diff Detail

Repository
R865 gajim
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

cigh033 created this revision.May 2 2018, 6:53 PM
cigh033 requested review of this revision.May 2 2018, 6:53 PM
  • This patch should depend on D2836
  • You should add a brief summary of what's new and a link to the changelog (basically you can take what's on the official site)

Further tests should be performed because for sure this package misses dependencies for the python3 / GTK+3 port.

package.yml
5–6

Should be updated to SPDX 3.X license code

12–13

Can be removed (because I made it a dependency of python-openssl)

12–13

Can be removed because it's a dependency of python-cryptography

13–14

This is in contradiction with your summary

Update gajim to version 1.0.2 (now with GTK3/Python3)

kyrios123 added inline comments.May 2 2018, 7:34 PM
package.yml
12

This is for python2 only.

cigh033 added a child revision: Restricted Differential Revision.May 2 2018, 9:18 PM
cigh033 edited the summary of this revision. (Show Details)May 3 2018, 8:12 AM
cigh033 updated this revision to Diff 6965.May 3 2018, 8:17 AM

did what kyrios123 said.

after my diffusion mess yesterday (sorry...) i was about to change the things you told me to.
After i did that, I found out about the problems you had with the Update to 1.0.X (https://dev.solus-project.com/feed/6545371174190833720/).
I looked into it a bit and it seems like an error that was seemingly fixed by the gajim devs before the release. After a bit of more digging I found out, there are some non ascii characters in our /etc/ssl/certs/*, that nbxmpp does not like

Any suggestions?

cigh033 marked 5 inline comments as done.May 3 2018, 11:20 AM

after my diffusion mess yesterday (sorry...) i was about to change the things you told me to.
After i did that, I found out about the problems you had with the Update to 1.0.X (https://dev.solus-project.com/feed/6545371174190833720/).
I looked into it a bit and it seems like an error that was seemingly fixed by the gajim devs before the release. After a bit of more digging I found out, there are some non ascii characters in our /etc/ssl/certs/*, that nbxmpp does not like
Any suggestions?

Could you please provide the link where you saw that an error was seemingly fixed by the gajim devs before the release ?
Could you please also share the details about the non ascii characters in our /etc/ssl/certs/* (it's probably better to open a new task to report this bug)

I completely forgot that I already gave a quick try to that package. I can share what I did, so you already have some of the python3 dependencies but keep in mind it was a work in progress and there might be missing things or things to fix.

Some remarks:

  • Obviously there are no build dependencies required (at least if unit tests aren't used as it is currently the case)
  • I moved some of the rundeps in the nbxmpp package. It is not mandatory, if you leave them all on the gajim package it will work fine, but in case some other packages uses nbxmpp later, they will most likely also need these runtime dependencies too.

Could you please provide the link where you saw that an error was seemingly fixed by the gajim devs before the release ?

https://dev.gajim.org/gajim/python-nbxmpp/issues/51 this is the specific issue that caused the commit, that "fixes" the issue.

Could you please also share the details about the non ascii characters in our /etc/ssl/certs/* (it's probably better to open a new task to report this bug)

I will open a bug after work later today.

I completely forgot that I already gave a quick try to that package. I can share what I did, so you already have some of the python3 dependencies but keep in mind it was a work in progress and there might be missing things or things to fix.

Some remarks:

  • Obviously there are no build dependencies required (at least if unit tests aren't used as it is currently the case)
  • I moved some of the rundeps in the nbxmpp package. It is not mandatory, if you leave them all on the gajim package it will work fine, but in case some other packages uses nbxmpp later, they will most likely also need these runtime dependencies too.

Thank you for the notes. I will look into it after work later today.

Thank you for the support for a guy new to packaging ;)

https://dev.gajim.org/gajim/python-nbxmpp/issues/51 this is the specific issue that caused the commit, that "fixes" the issue.

On then that's cool we can just cherry-pick the commit and apply the patch.

I will open a bug after work later today.

Not required anymore since it was an upstream bug and we can apply the above patch.

Thank you for the support for a guy new to packaging ;)

We're all here to contribute to a great project and help making it better
I just share what I learned with the help of other people and maybe later you'll do the same ?

On then that's cool we can just cherry-pick the commit and apply the patch.

Sorry if i may have confused you. The issue (that is not our issue here) was fixed in a version prior the one i packaged with D2836, so the error is pretty much the same but our problem is another one, so i opened task T6317

https://dev.gajim.org/gajim/python-nbxmpp/issues/51 this is the specific issue that caused the commit, that "fixes" the issue.

On then that's cool we can just cherry-pick the commit and apply the patch.

I will open a bug after work later today.

Not required anymore since it was an upstream bug and we can apply the above patch.

Thank you for the support for a guy new to packaging ;)

We're all here to contribute to a great project and help making it better
I just share what I learned with the help of other people and maybe later you'll do the same ?

Gajim is lacking some notable features and I've opened a ticket for it https://dev.solus-project.com/T6041

JoshStrobl accepted this revision.May 19 2018, 3:53 PM
This revision is now accepted and ready to land.May 19 2018, 3:53 PM
JoshStrobl closed this revision.May 19 2018, 4:17 PM

Okay so @cigh033, for whatever reason Arcanist is being a tool and not letting me apply this. Gonna apply it via a patch manually and close the diff. I appreciate all the work you've put in on this :)