Page MenuHomeSolus

Initial commit of milkytracker
ClosedPublic

Authored by cigh033 on Apr 26 2018, 10:28 AM.

Details

Summary

Initial commit of milkytracker. Resolves T4889

Test Plan
  • installed
  • ran the application
  • clicked a bit, loaded and saved a file
  • console output contains no errors

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

cigh033 created this revision.Apr 26 2018, 10:28 AM
cigh033 requested review of this revision.Apr 26 2018, 10:28 AM
JoshStrobl requested changes to this revision.May 19 2018, 3:48 PM
JoshStrobl added a subscriber: JoshStrobl.

Needs an icon if one is available for it.

package.yml
14–16

pkgconfigs need to be alphabetized and listed above alsa-tools

This revision now requires changes to proceed.May 19 2018, 3:48 PM
cigh033 updated this revision to Diff 7443.May 28 2018, 7:24 PM

changed order of dependencies, added icon and updated license

cigh033 marked an inline comment as done.Jun 1 2018, 8:30 AM
JoshStrobl accepted this revision.Jun 4 2018, 8:30 AM
JoshStrobl retitled this revision from initial commit of milkytracker to Initial commit of milkytracker.
JoshStrobl edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Jun 4 2018, 8:31 AM
JoshStrobl requested changes to this revision.Jun 4 2018, 8:34 AM

Hey, gonna need you to push this as a complete commit instead of just modifications, since it's trying to base the work on the previous differential and its commit, which doesn't exist.

This revision now requires changes to proceed.Jun 4 2018, 8:34 AM

Hey, sorry, I'm a bit slow today, what do you want me to do? Just create a new diff with "arc diff"?

Given I don't know your local git commit history, I'd suggest creating a new git repository, adding these files, and creating a new initial commit so all the commit changes are additions. After that, attempt running arc diff --update D2805.

If you have multiple commits in your master branch, you need to squash your commits (and in the future amend existing commits rather than making new ones), following the information at: https://solus-project.com/articles/packaging/submitting-a-package/en/#updating-files

cigh033 updated this revision to Diff 7494.Jun 4 2018, 4:49 PM

re-initialized repository

JoshStrobl accepted this revision.Jun 4 2018, 4:52 PM
This revision is now accepted and ready to land.Jun 4 2018, 4:52 PM
This revision was automatically updated to reflect the committed changes.

Thanks again for all your work on this ?