Page MenuHomeSolus
Differential D2777

python-itsdangerous: enable python3 & add unit tests
ClosedPublic
Actions

Authored by kyrios123 on Apr 23 2018, 3:46 PM.
Tags
None
Referenced Files
F11055092: D2777.id.diff
Fri, Aug 11, 1:26 AM
F11055091: D2777.id6847.diff
Fri, Aug 11, 1:26 AM
F11055090: D2777.id9174.diff
Fri, Aug 11, 1:26 AM
F11038412: D2777.diff
Wed, Aug 9, 10:39 PM
F10897430: D2777.diff
Jul 2 2023, 6:59 AM
F10877124: D2777.diff
Jun 20 2023, 4:15 PM
F10831456: D2777.id9174.diff
Jun 5 2023, 12:00 PM
F10781635: D2777.id.diff
May 25 2023, 8:54 AM
View All 12 Files
Subscribers
DataDrake
JoshStrobl

Details

Reviewers
JoshStrobl
DataDrake
Group Reviewers
Triage Team
Commits
R2605:87fb51f6a0a6: python-itsdangerous: enable python3 & add unit tests
Summary

I need a python 3 build of flask for pgadmin4.
I have also switched the source to a more human friendly URL.

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan
  • Unit tests enabled
  • Success fully build flask against this version

Diff Detail

Repository
R2605 python-itsdangerous
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kyrios123 created this revision.Apr 23 2018, 3:46 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptApr 23 2018, 3:46 PM
kyrios123 requested review of this revision.Apr 23 2018, 3:46 PM
kyrios123 added a child revision: D2778: Update flask to 1.0.2 and add python3 support.Apr 23 2018, 5:00 PM
JoshStrobl requested changes to this revision.May 19 2018, 3:45 PM
JoshStrobl added a subscriber: JoshStrobl.

Should be tested against mkchromecast if you have one available. If not I can test it.

This revision now requires changes to proceed.May 19 2018, 3:45 PM
kyrios123 added a comment.EditedMay 19 2018, 6:14 PM
In D2777#46679, @JoshStrobl wrote:

Should be tested against mkchromecast if you have one available. If not I can test it.

I don't have a chromecast anymore. You can test it when you have time. Thanks, @JoshStrobl !

kyrios123 mentioned this in D3559: Enabling python 3 bindings for onionshare T5181.Aug 15 2018, 9:54 AM
Devil505 added a child revision: D3560: Enable python 3 bindings needed for onionshare T5181.Aug 23 2018, 5:38 PM
kyrios123 added a comment.Aug 24 2018, 6:55 PM

Now I think about it, there was no version bump or deep packaging modification. Only python 3 and unit tests were added.

kyrios123 requested review of this revision.Aug 24 2018, 6:56 PM
DataDrake accepted this revision.Aug 25 2018, 6:53 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Aug 25 2018, 6:54 PM
Closed by commit R2605:87fb51f6a0a6: python-itsdangerous: enable python3 & add unit tests (authored by kyrios123, committed by DataDrake). · Explain Why
This revision was automatically updated to reflect the committed changes.
DataDrake removed a child revision: D3560: Enable python 3 bindings needed for onionshare T5181.Aug 25 2018, 6:57 PM

Revision Contents
Changeset List

PathSize
13 lines
19 lines

Diff 6847

View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.