Page MenuHomeSolus

Update ffmpeg to 4.1
ClosedPublic

Authored by kyrios123 on Apr 20 2018, 8:38 PM.

Details

Summary

Please check the NEWS for details about version 4 and the changelog for more details.

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

See here

Note: GnuTLS was removed from the dependencies because GnuTLS and OpenSSL must not be enabled at the same time.

Diff Detail

Repository
R742 ffmpeg
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kyrios123 created this revision.Apr 20 2018, 8:38 PM
kyrios123 requested review of this revision.Apr 20 2018, 8:38 PM
kyrios123 edited the test plan for this revision. (Show Details)Apr 21 2018, 3:41 PM

Status updated on 11/11/2018 - ffmpeg 4.1

NameComment (blank means ok)
ffmpegupdate to 4.1
gegl
qt5-webengine
gstreamer-1.0-libavnext version 1.16 will support ffmpeg 4.x. ( alternative: build --without-system-libav )
openjfx-8fails to build, not ffmpeg related
libopenshot
vapoursynth
mlt
chromaprint
vlc
ffmpegthumbs
deadbeef
obs-studio
attract
pianobar
ffmpegthumbnailer
hedgewars
mgba
simplescreenrecorder
goldendictpatched (fmmpeg4 & qt5.11)
winff
usdxuse latest git
spek
qnapino rebuild needed
streamlinkno rebuild needed
aubioupdated to 0.4.7
openfx-io
unpaperfix docbook stylesheet path
gifskiffmpeg4 won't be supported - updated to 0.8.5 as I had to edit the package to disable video
mkchromecastno rebuild needed
dsp
guvcview
audacity
audacious-plugins
retroarch
mocpatch & add db5-devel builddep
freerdp
minidlna
vcmi
opalThe best I have found is this at the same time there is a request to remove opal/ekiga from debian. --disable-libavcodec build option available
mpvupdate to 0.29.1 (vulkan & wayland-protocols builddeps added)
mpd
cantata
kfilemetadata
k3b
kritano rebuild needed
blenderpatched (ffmpeg4 & gcc8)
firefoxno rebuild needed
openmw
dolphin-emu
cmus
svtplay-dlno rebuild needed
openscenegraph
ffms2
opencv
qtoxhave to disable -Werror
kyrios123 retitled this revision from Update ffmpeg to 4.0 to [WIP] Update ffmpeg to 4.0.May 18 2018, 3:41 PM

Update 25/06/18 : it looks like only attract is still an issue for ffmpeg 4.0.x

Update 25/06/18 : it looks like only attract is still an issue for ffmpeg 4.0.x

Are you sure? It appears you have just disabled it for 4 of the packages

Jacalz added a subscriber: Jacalz.EditedJul 17 2018, 11:11 AM

Any news on getting this fixed? I think svtplay-dl might need to be checked also against ffmpeg 4...

In D2767#52672, @Jacalz wrote:

Any news on getting this fixed? I think svtplay-dl might need to be checked also against ffmpeg 4...

attract version 2.4 was release a few days ago so I may give it a try. I also have to check the few packages for on which system ffmpeg was disabled (or for which ffmpeg was fully disabled) but I fear it is still a bit too early to have everything compliant.
svtplay-dl won't have any issue with this update because it just trigger the ffmpeg command line utility for post-processing and doesn't make use of the api/libraries.

Okay, thanks for the update @kyrios123

I submitted a few patches to update some of the applications that had to be updated/patched when I did the rebuild. This should make the ffmpeg 4.x update smoother when it will be ready.

makemkv is also a blocker for this update.

Tick added a subscriber: Tick.Jul 24 2018, 6:44 PM

Is it very relevant to keep MakeMkv ? It seems barely dead ( https://www.makemkv.com/forum2/viewtopic.php?f=3&t=17550 ), no real cvs (git, svn ...), there are plenty of alternatives

kyrios123 updated this revision to Diff 8753.Aug 10 2018, 3:21 PM
kyrios123 retitled this revision from [WIP] Update ffmpeg to 4.0 to [WIP] Update ffmpeg to 4.0.2.

Rebase & update to 4.0.2 for T6762

gstreamer-1.0-libav builds fine with this patch but seeing it's a WIP, I guess it is still too early to switch to ffmpeg 4.x
I guess we'll have to wait for gstreamer 1.16

While this may be controversial, I think to get past opal we should simply deprecate it and ekiga. Ekiga is the only revdep of opal and it hasn't seen an update since 2013.

@kyrios123 libopenshot should be buildable with ffmpeg 4.x as of release 0.2.2, can you recheck that and update the revdeps list of blockers?

Whilst a personal pet-peeve of mine, from my understanding, this is also required to fix hardware video decoding colours on radeon/amdgpu with vaapi.

@kyrios123 libopenshot should be buildable with ffmpeg 4.x as of release 0.2.2, can you recheck that and update the revdeps list of blockers?

I know for sure the main blocker is gstreamer-1.0-libav. Would it be acceptable to build it --without-system-libav (or we with the WIP patches (sic!!!!) I mentionned above) ?
If not, we'll have to wait for gstreamer 1.16 to update ffmpeg to 4.x

Please let me know since I don't really want to review the list is this is already a no go !

@kyrios123 libopenshot should be buildable with ffmpeg 4.x as of release 0.2.2, can you recheck that and update the revdeps list of blockers?

I know for sure the main blocker is gstreamer-1.0-libav. Would it be acceptable to build it --without-system-libav (or we with the WIP patches (sic!!!!) I mentionned above) ?
If not, we'll have to wait for gstreamer 1.16 to update ffmpeg to 4.x

Please let me know since I don't really want to review the list is this is already a no go !

That literally didn't answer my question whatsoever. Please answer my original question and get the revdeps list of blockers update so I can do a final assessment. Thanks.

That literally didn't answer my question whatsoever. Please answer my original question and get the revdeps list of blockers update so I can do a final assessment. Thanks.

Status has been updated in the above comment. Build was done against ffmpeg 4.1

kyrios123 updated this revision to Diff 10552.Nov 8 2018, 10:01 PM
kyrios123 retitled this revision from [WIP] Update ffmpeg to 4.0.2 to [WIP] Update ffmpeg to 4.1.
kyrios123 edited the summary of this revision. (Show Details)
kyrios123 edited the test plan for this revision. (Show Details)

Bump to 4.1

JoshStrobl accepted this revision.Fri, Dec 7, 12:03 AM

Okay, so here's where I'm at with this. I'm not gonna drag my feet waiting on reverse deps which aren't going to see updates, such as opal and ekiga as I've remarked before. For gifski, this will almost certainly negatively functionality in peek, but we can just remove the gif support from Peek and call it a day with that. For gstreamer-1.0-libav, we'll build it without the system ffmpeg. It's a temporary "issue" with a temporary solution until 1.16 is stable, so I'm not going to consider it a blocker.

I'm not seeing any other obvious blockers for this, so let's schedule sometime early next week (week 50) to start doing this upgrade. @kyrios123 if you want me to take lead on it, I can, no problemo. Otherwise just let me know when you are available for early next week and we both can sit down and sort this upgrade out.

This revision is now accepted and ready to land.Fri, Dec 7, 12:03 AM
kyrios123 updated this revision to Diff 11229.Fri, Dec 7, 5:09 PM

Rebase because someone wants to make my life harder...

Okay, so here's where I'm at with this. I'm not gonna drag my feet waiting on reverse deps which aren't going to see updates, such as opal and ekiga as I've remarked before. For gifski, this will almost certainly negatively functionality in peek, but we can just remove the gif support from Peek and call it a day with that. For gstreamer-1.0-libav, we'll build it without the system ffmpeg. It's a temporary "issue" with a temporary solution until 1.16 is stable, so I'm not going to consider it a blocker.

I'm not seeing any other obvious blockers for this, so let's schedule sometime early next week (week 50) to start doing this upgrade. @kyrios123 if you want me to take lead on it, I can, no problemo. Otherwise just let me know when you are available for early next week and we both can sit down and sort this upgrade out.

Everything is ready. As requested I used a git source for goldendict. Only opnejfx fails to build unless I use D4119.

This revision was automatically updated to reflect the committed changes.
kyrios123 retitled this revision from [WIP] Update ffmpeg to 4.1 to Update ffmpeg to 4.1.Tue, Dec 11, 11:30 AM