Page MenuHomeSolus

Needed for kwalletcli, fixes T6236
AbandonedPublic

Authored by stobbsm on Apr 19 2018, 9:45 PM.
Tags
None
Referenced Files
F11004321: D2755.diff
Tue, Aug 1, 12:26 AM
F10987639: D2755.diff
Mon, Jul 24, 6:28 AM
F10864051: D2755.diff
Jun 17 2023, 5:48 AM
F10840713: D2755.id6804.diff
Jun 10 2023, 2:52 AM
F10826415: D2755.diff
Jun 4 2023, 2:50 AM
F10757185: D2755.id6804.diff
May 17 2023, 7:35 AM
F10739466: D2755.diff
May 13 2023, 7:46 PM
F10737341: D2755.id.diff
May 13 2023, 3:34 AM

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T3625: Mksh
Summary

mksh is needed as the shell to be used for kwalletcli

Test Plan

Ensure it starts, but tests fail when run through solbuild. Tests work as expected when not in a container.

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
11

if all you need is glibc, no need to list builddeps. Anything in system.base or system.devel is superfluous.

14

you don't need to cd to $workdir. you are already there.

17

Again.

18

Should be install -Dm00755 mksh $installdir/bin/mksh

19

Not needed.

20

Should be install -Dm00644 dot.mkshrc $installdir/usr/share/doc/mksh/examples/dot.mkshrc

21

Again.

22

Should be install -Dm00644 mksh.1 $installdir/usr/share/man/man1/mksh.1

Why you would add lksh.1 if there is no executable?

This revision now requires changes to proceed.Aug 18 2018, 8:21 PM

Per other patch, needs the correct formatting

Closing due to lack of activity in over 30 days.