Page MenuHomeSolus

Needed for kwalletcli, fixes T6236
AbandonedPublic

Authored by stobbsm on Apr 19 2018, 9:45 PM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T3625: Mksh
Summary

mksh is needed as the shell to be used for kwalletcli

Test Plan

Ensure it starts, but tests fail when run through solbuild. Tests work as expected when not in a container.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
stobbsm created this revision.Apr 19 2018, 9:45 PM
stobbsm requested review of this revision.Apr 19 2018, 9:45 PM

This package is required for D2754.

DataDrake requested changes to this revision.Aug 18 2018, 8:21 PM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
11

if all you need is glibc, no need to list builddeps. Anything in system.base or system.devel is superfluous.

14

you don't need to cd to $workdir. you are already there.

17

Again.

18

Should be install -Dm00755 mksh $installdir/bin/mksh

19

Not needed.

20

Should be install -Dm00644 dot.mkshrc $installdir/usr/share/doc/mksh/examples/dot.mkshrc

21

Again.

22

Should be install -Dm00644 mksh.1 $installdir/usr/share/man/man1/mksh.1

Why you would add lksh.1 if there is no executable?

This revision now requires changes to proceed.Aug 18 2018, 8:21 PM

Per other patch, needs the correct formatting

DataDrake abandoned this revision.Oct 20 2018, 4:05 PM

Closing due to lack of activity in over 30 days.