Page MenuHomeSolus

Update digikam to 5.9.0
ClosedPublic

Authored by kyrios123 on Mar 28 2018, 6:44 PM.
Tags
None
Referenced Files
F11050804: D2633.id.diff
Thu, Aug 10, 7:21 PM
F11050803: D2633.id6578.diff
Thu, Aug 10, 7:21 PM
F11050802: D2633.id6538.diff
Thu, Aug 10, 7:21 PM
F11050801: D2633.id6572.diff
Thu, Aug 10, 7:21 PM
F11050800: D2633.id6571.diff
Thu, Aug 10, 7:21 PM
F11035934: D2633.diff
Wed, Aug 9, 6:38 PM
F11017214: D2633.diff
Sat, Aug 5, 11:54 PM
F10965373: D2633.id.diff
Wed, Jul 19, 8:36 PM
Subscribers

Details

Summary

Changelog available here

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

Open, modyfy & save an image

Diff Detail

Repository
R625 digikam
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

This revision is now accepted and ready to land.Mar 31 2018, 5:58 PM
sunnyflunk added a subscriber: sunnyflunk.
sunnyflunk added inline comments.
package.yml
6

You dropped a license... Pretty important for other things to link against it. Also they are both or-later licenses as stated in the license files

This revision now requires changes to proceed.Mar 31 2018, 9:54 PM

Fix: license

@sunnyflunk aren't you supposed to be on vacation ? ;-)

PS: If you compare the license on SPDX, you'll see that the text is always the same for the only and the or-later, so I use only by default unless I find an explicit mention saying that indicates a later version can be used (in a readme, on the web site, on a shipped .spec file/debian copyright file). For digikam, I havn't found anything that suggest that a later version of the license can be used.

I'll admit I read what it said incorrectly at first. What I believe to be the distinction between the two licensees is the license header they add to the source files. If you read at the very bottom of the license it tells you about how you should add a little spiel (standard license header) to all the files. This is the part that differs between the two, while the rest of the license is identical. Here it states that you include the 'or at your option any later version' for the -or-later license, where if you wish it to be -only that version of the license, it should not mention other versions in the file headers.

I don't think pulling out, moving and restacking 14 tonnes of wood counts as a holiday xD

This revision is now accepted and ready to land.Apr 1 2018, 7:00 AM
package.yml
5–6

Actually make sure you fix this on merge. -or-later

This revision was automatically updated to reflect the committed changes.