Details
Details
- Reviewers
JoshStrobl - Group Reviewers
Triage Team - Maniphest Tasks
- T6413: Update inkscape to 0.92.3
- Commits
- R1470:a7e124fa8653: Update inkscape to 0.92.3
Run app, draw something, save & reopen the file.
Diff Detail
Diff Detail
- Repository
- R1470 inkscape
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
I did some cleanup in the package
- Remove unneeded dependencies
- The poppler patch isn't necessary anymore
- I don't understand the sed's since the defaut python interpreter is python 2 (perhaps it was copied from Arch?)
- Remove the --disable-dependency-tracking. Why was is disabled? to speed up the build ?
I still have some concerns: when I look at the build logs, I see that dbus and gnome-vfs are not enabled but there are build dependencies for them. So is the intention to have them enabled or should these dependencies be dropped as well?
Comment Actions
Regarding:
- dbus, please pass --enable-dbusapi=yes, since apparently their default is no. If it still fails, just drop it.
- Regarding gnome-vfs-2.0 / gnome-vfs, their check fails and frankly it hasn't been used this entire time, so may as well drop it.
Rest of the cleanup looks fine ?