Page MenuHomeSolus
Differential D2622

Fixing the broken pkgconfig file of openjp2
AbandonedPublic
Actions

Authored by xulongwu4 on Mar 26 2018, 4:39 PM.
Tags
None
Referenced Files
F11054447: D2622.id6527.diff
Fri, Aug 11, 12:49 AM
F11054445: D2622.id6523.diff
Fri, Aug 11, 12:49 AM
F11054444: D2622.id.diff
Fri, Aug 11, 12:49 AM
F11038165: D2622.diff
Wed, Aug 9, 10:09 PM
F10992605: D2622.diff
Tue, Jul 25, 12:07 PM
F10972793: D2622.id6527.diff
Fri, Jul 21, 4:09 PM
F10930072: D2622.id6523.diff
Jul 11 2023, 10:39 AM
F10767173: D2622.id.diff
May 19 2023, 10:34 PM
Subscribers
kyrios123
• sunnyflunk

Details

Reviewers
None
Group Reviewers
Triage Team
Summary

The current installation of openjpeg-devel has a broken pkgconfig file.

pkg-config --libs libopenjp2 produces -L/usr//usr/lib64 -lopenjp2, which causes the link to libopenjp2 broken in building software.

The issue is that one should only specify a relative library path to the install prefix rather than an absolute path.

After the fix, the output of pkg-config --libs libopenjp2 is -lopenjp2.

Test Plan

Installed the fix and checked the pkgconfig file. It works as expected.

Diff Detail

Repository
R2244 openjpeg
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

xulongwu4 created this revision.Mar 26 2018, 4:39 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptMar 26 2018, 4:39 PM
xulongwu4 requested review of this revision.Mar 26 2018, 4:39 PM
xulongwu4 updated this revision to Diff 6527.Mar 26 2018, 6:32 PM

Use lib%LIBSUFFIX% for the lib directory

• sunnyflunk added a subscriber: • sunnyflunk.Apr 14 2018, 4:59 AM

D1156 and D2622 need to be combined as only one can land.

xulongwu4 added a subscriber: kyrios123.Apr 14 2018, 1:20 PM
In D2622#42933, @sunnyflunk wrote:

D1156 and D2622 need to be combined as only one can land.

@kyrios123 Do you mind adding this fix to your patch. It is a really simple fix and if you can pull it into your patch, I am happy to close this one.

kyrios123 mentioned this in D1156: Update openjpeg to 2.3.0.Apr 15 2018, 8:02 AM
kyrios123 abandoned this revision.Apr 15 2018, 8:03 AM

Your changes have been merged into D1156, thanks ! ?

Revision Contents
Changeset List

PathSize
4 lines
14 lines

Diff 6523

View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.