Initial commit of utopia-documents. Resolves T642
Details
- Reviewers
DataDrake - Group Reviewers
Triage Team - Maniphest Tasks
- T642: Utopia Documents
- Commits
- R4209:d762cdcd13bc: Initial commit of utopia-documents
Used it to view scholar papers and related info shows up in the side panel
Diff Detail
- Repository
- R4209 utopia-documents
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
- The networking option is not necessary after switching to system poppler library and adding pytest-runner as a builddep
- Add python-pillow to rundep
Do you mean moving the directory /usr/lib/utopia-documents/lib to /usr/lib64? Right now there are three sub-directories in /usr/lib/utopia-documents: lib/, plugins/, python/. As a package I think it makes sense to put all the dependencies in a single folder /usr/lib/utopia-documents. So in your opinion, we can move the libraries in /usr/lib/utopia-documents/lib to /usr/lib64 or we should also move the other two?
So looking closer I really expected to see:
/usr/lib/utopia-documents/lib in /usr/lib64/utopia-documents
/usr/lib/utopia-documents/plugins in /usr/lib64/utopia-documents/plugins
and
/usr/lib/utopia-documents/python in the actual /usr/lib64/python2.7/site-packages directory
Rearrange the installed package. Now the libraries are installed in /usr/lib (which is a symlink to /usr/lib64).
The python packages are in /usr/lib/python2.7/site-packages. The plugins are in /usr/lib/utopia-documents/plugins.
There is a reason why we want things to be in /usr/lib64 as we would like to drop the symlink at some stage, which can only happen when no package uses the path.
However, you do want to leave the python files in the /usr/lib path (how you've fixed it already is correct), as the python path needs to be fixed in the python2 itself with a full stack rebuild (which can't happen till after eopkg is killed).
Then once python is fixed, this package will be ready for dropping the symlink.
| files/0004-cmake-set-python-and-library-path.patch | ||
|---|---|---|
| 13 | Surely can just be lib64, but leave python where it is | |
| 15 | This probably wants to be lib64/utopia-documents/plugins | |
@DataDrake @sunnyflunk Thanks for the detailed explanation for explicitly using /usr/lib64 rather than the symlink. The patch is updated accordingly.
Now the libraries and plugins are in /usr/lib64 and /usr/lib64/utopia-documents/plugins respectively. The python package is in /usr/lib/python2.7/site-packages.