Differential D256

youtube-viewer: initial inclusion
AbandonedPublic
Actions

Authored by joebonrichie on May 29 2017, 11:05 PM.

Details

Reviewers

• sunnyflunk

Group Reviewers

Triage Team

Maniphest Tasks

T2210: gtk-youtube-viewer

Summary

Version 3.2.8
Built with full GTK support
TODO: Change default config file to add gnome-mpv as an option

Test Plan

tested playing vidoes from cli and gui to mpv
logged in from the gui, could view my subcriptions, etc.
Ensured the .desktop file was installed correctly
Tested the man file worked

Diff Detail

Branch

arcpatch-D256

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

joebonrichie created this revision.May 29 2017, 11:05 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptMay 29 2017, 11:05 PM

A somewhat complex dependency stack to upload, please hold off on review.

joebonrichie added a parent revision: D257: gtk2-perl: initial inclusion.May 29 2017, 11:10 PM

joebonrichie added a parent revision: D262: libwww-perl: update to 3.26.May 29 2017, 11:19 PM

joebonrichie added parent revisions: D269: perl-file-sharedir: add perl-class-inspector as a rundep, D270: perl-json-xs: initial inclusion.May 29 2017, 11:34 PM

joebonrichie added parent revisions: D274: perl-term-readline-gnu: initial inclusion, D275: perl-text-charwidth: initial inclusion.May 29 2017, 11:42 PM

Think i got all the dependencies. Feel free to review now.

Updated to 3.2.8

LGTM, thanks

This revision is now accepted and ready to land.Jun 29 2017, 3:21 AM

So I broke arcanist it seems, but decided to get these diffs in manually to finish it off. Having a play with youtube-viewer, it wasn't loading with vlc (maybe it needs a rebuild for changes in qt-5.9), but worked with mpv.

Something to look at and can then make config changes if required. You'll need to clone the Solus repos to make any changes https://dev.solus-project.com/source/youtube-viewer/ especially as they will differ slightly from how they got landed. Seems pretty easy to change the defaults.

Thanks for sorting out all the deps! ?