Page MenuHomeSolus

The inclusion of bookworm fixes T5378
ClosedPublic

Authored by Devil505 on Mar 18 2018, 7:14 AM.
Tags
None
Referenced Files
F11066375: D2562.diff
Fri, Aug 11, 6:00 PM
F11009832: D2562.diff
Wed, Aug 2, 8:08 PM
F10984422: D2562.id6409.diff
Sun, Jul 23, 5:41 PM
F10898611: D2562.diff
Jul 3 2023, 3:32 AM
F10843576: D2562.id6409.diff
Jun 10 2023, 6:32 PM
F10841447: D2562.id6253.diff
Jun 10 2023, 7:17 AM
F10834964: D2562.diff
Jun 7 2023, 6:31 PM
F10784093: D2562.id.diff
May 25 2023, 11:09 PM

Details

Summary

ebook reader

Test Plan

The application launched properly.

I opened some ebook files with it, seems to work perfectly.

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Does the function check for the meaning of a word work for you? I compiled it as well and this is the only thing which isn't working and I get a GLib warning if I run it with --debug

Does the function check for the meaning of a word work for you? I compiled it as well and this is the only thing which isn't working and I get a GLib warning if I run it with --debug

I didn't check this function. You're right nothing happen on my side when I click on it.
I also have [WARNING 14:19:11.256326] [GLib] Invalid file descriptor
but I think it's just a warning.

@Girtablulu I've tested bookworm on elementary OS with Virtualbox, nothing happen when I click on "display meaning of the word" so maybe it's a issue from bookworm not Solus.

I tried with a french ebook downloaded from framabook, maybe this function works with an ebook in English, I don't know...

Sounds like it is looking for either an executable or file to open when it does the meaning lookup. Can you strace it and tell me what file it tries to open?

Is the function buggy or do we need to activate something else? I didn't find any information regarding this.

joebonrichie added a subscriber: joebonrichie.

It looks like check word meaning is not implemented yet, it shouldn't be exposed as a setting.
https://github.com/babluboy/bookworm/blob/master/src/window.vala#L362

Otherwise, LGTM.

This revision is now accepted and ready to land.Mar 21 2018, 5:17 PM

In the future, make sure you aren't missing the abi_* files

This revision was automatically updated to reflect the committed changes.