ebook reader
Details
- Reviewers
joebonrichie - Group Reviewers
Triage Team - Maniphest Tasks
- T5378: Bookworm
- Commits
- R4172:27e5e312db1a: The inclusion of bookworm fixes T5378
The application launched properly.
I opened some ebook files with it, seems to work perfectly.
Diff Detail
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Does the function check for the meaning of a word work for you? I compiled it as well and this is the only thing which isn't working and I get a GLib warning if I run it with --debug
I didn't check this function. You're right nothing happen on my side when I click on it.
I also have [WARNING 14:19:11.256326] [GLib] Invalid file descriptor
but I think it's just a warning.
@Girtablulu I've tested bookworm on elementary OS with Virtualbox, nothing happen when I click on "display meaning of the word" so maybe it's a issue from bookworm not Solus.
I tried with a french ebook downloaded from framabook, maybe this function works with an ebook in English, I don't know...
Sounds like it is looking for either an executable or file to open when it does the meaning lookup. Can you strace it and tell me what file it tries to open?
Is the function buggy or do we need to activate something else? I didn't find any information regarding this.
It looks like check word meaning is not implemented yet, it shouldn't be exposed as a setting.
https://github.com/babluboy/bookworm/blob/master/src/window.vala#L362
Otherwise, LGTM.