initial release of pdfpc
ClosedPublic
Actions

Authored by Girtablulu on Mar 16 2018, 2:43 PM.

Details

Reviewers

JoshStrobl
DataDrake

Group Reviewers

Triage Team

Maniphest Tasks

T5541: the pdfpc package

Commits

R4207:eacbaea3a093: initial release of pdfpc

Summary

Initial release of pdfpc

Test Plan

tested it with Simple demo and Embedded movies both did run fine
- resolves T5541

Diff Detail

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

Girtablulu created this revision.Mar 16 2018, 2:43 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptMar 16 2018, 2:43 PM

Girtablulu requested review of this revision.Mar 16 2018, 2:43 PM

xulongwu4 added a subscriber: xulongwu4.Mar 16 2018, 4:17 PM

Also does this not include a desktop file and pixmap for you to use?

package.yml
7	Should probably be `office.viewers` instead.
15	Unnecessary, it's a dependency of `gstreamer-1.0-plugins-base-devel`
18	Not necessary, dependency of 'libgtk-3-devel`
pspec_x86_64.xml
27	Not a valid path. Should just be `/etc/pdfpcrc`

This revision now requires changes to proceed.Mar 17 2018, 2:09 PM

@JoshStrobl regarding the desktop file and icon, as far as I can see this PDF viewer only gets started over CLI so that's why I thought a desktop file is not needed and I searched for an Icon for the software and the only icons it has are for the software UI nothing for displaying inside your panel menu