Resolves T334.
Details
Details
- Reviewers
joebonrichie JoshStrobl - Group Reviewers
Triage Team - Maniphest Tasks
- T334: Brave Browser Package
- Commits
- R4107:e2200fc1cc47: Initial Inclusion of brave
Open the browser and browse some popular sites.
Diff Detail
Diff Detail
- Repository
- R4107 brave
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Change the default shortcut for switching tabs, because the default overrides
the globale workspace switching shortcut of budgie, to only using Ctrl instead
of using Ctrl+Alt.
Comment Actions
Looks good overall, just a few issues to sort out before we can include it.
| package.yml | ||
|---|---|---|
| 7 | Licence is not custom, please read the LICENSE.txt file and use the appropriate identifiers from https://spdx.org/licenses/. | |
| 9 | I would consider using a different summary, this is Linux we don't really care that's it's available for MacOS and Windows. | |
| 14 | To fix errors at the end of the build such as Fatal: Unknown symbol: libXcursor.so.1 you need the following builddeps: - pkgconfig(alsa) - pkgconfig(fontconfig) - pkgconfig(gconf-2.0) - pkgconfig(gtk+-3.0) - pkgconfig(xscrnsaver) - cups-devel | |
| 15 | yarn depends on nodejs so adding nodejs as a builddep is not necessary. | |
| 28–29 | Very nitpicky but the quotations are not necessary | |
| package.yml | ||
|---|---|---|
| 30 | Should be able to do: CHANNEL=dev yarn build-package | |
| package.yml | ||
|---|---|---|
| 18 | Not unecessary, fontconfig-devel is a dep of libgtk-3-devel. *smacks* @joebonrichie | |
| package.yml | ||
|---|---|---|
| 18 | Apparently I can't edit my comment, cool. I meant "Not necessary". | |