Page MenuHomeSolus

Initial Inclusion of brave
ClosedPublic

Authored by taaem on Mar 13 2018, 3:20 PM.

Details

Summary

Resolves T334.

Test Plan

Open the browser and browse some popular sites.

Diff Detail

Repository
R4107 brave
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

taaem created this revision.Mar 13 2018, 3:20 PM
taaem requested review of this revision.Mar 13 2018, 3:20 PM
logTom added a subscriber: logTom.Mar 13 2018, 3:29 PM
taaem updated this revision to Diff 6121.Mar 13 2018, 3:29 PM

Update the component

taaem updated this revision to Diff 6122.Mar 13 2018, 7:00 PM

Change the default shortcut for switching tabs, because the default overrides
the globale workspace switching shortcut of budgie, to only using Ctrl instead
of using Ctrl+Alt.

joebonrichie requested changes to this revision.Mar 13 2018, 7:08 PM
joebonrichie added a subscriber: joebonrichie.

Looks good overall, just a few issues to sort out before we can include it.

package.yml
7

Licence is not custom, please read the LICENSE.txt file and use the appropriate identifiers from https://spdx.org/licenses/.

9

I would consider using a different summary, this is Linux we don't really care that's it's available for MacOS and Windows.

14

To fix errors at the end of the build such as Fatal: Unknown symbol: libXcursor.so.1 you need the following builddeps:

- pkgconfig(alsa)
- pkgconfig(fontconfig)
- pkgconfig(gconf-2.0)
- pkgconfig(gtk+-3.0)
- pkgconfig(xscrnsaver)
- cups-devel
15

yarn depends on nodejs so adding nodejs as a builddep is not necessary.

28–29

Very nitpicky but the quotations are not necessary

This revision now requires changes to proceed.Mar 13 2018, 7:08 PM
taaem updated this revision to Diff 6123.Mar 13 2018, 7:32 PM

Updating the License and adding the correct build deps

JoshStrobl requested changes to this revision.Mar 13 2018, 7:40 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
30

Should be able to do: CHANNEL=dev yarn build-package

This revision now requires changes to proceed.Mar 13 2018, 7:40 PM
taaem updated this revision to Diff 6124.Mar 13 2018, 7:43 PM

Use yarn instead of npm to build the package

JoshStrobl added inline comments.Mar 13 2018, 7:52 PM
package.yml
18

Not unecessary, fontconfig-devel is a dep of libgtk-3-devel. *smacks* @joebonrichie

JoshStrobl added inline comments.Mar 13 2018, 7:53 PM
package.yml
18

Apparently I can't edit my comment, cool. I meant "Not necessary".

taaem updated this revision to Diff 6125.Mar 13 2018, 7:56 PM

Remove unecessary builddep fontconfig

JoshStrobl accepted this revision.Mar 13 2018, 7:57 PM

LGTM, will let @joebonrichie give it a pass too.

joebonrichie accepted this revision.Mar 13 2018, 8:43 PM
This revision is now accepted and ready to land.Mar 13 2018, 8:43 PM
This revision was automatically updated to reflect the committed changes.