Paths

Table of Contentst

Differential D2479

Update of qupzilla to falkon
ClosedPublic
Actions

Authored by Girtablulu on Mar 9 2018, 10:16 PM.

Tags

None

Referenced Files

	F11055139: D2479.id6175.diff
	Fri, Aug 11, 1:32 AM

	F11055138: D2479.id5994.diff
	Fri, Aug 11, 1:32 AM

	F11055137: D2479.id6011.diff
	Fri, Aug 11, 1:32 AM

	F11055136: D2479.id5995.diff
	Fri, Aug 11, 1:32 AM

	F11055135: D2479.id.diff
	Fri, Aug 11, 1:32 AM

	F11055134: D2479.id6017.diff
	Fri, Aug 11, 1:32 AM

	F11038475: D2479.diff
	Wed, Aug 9, 10:49 PM

	F10984257: D2479.id5995.diff
	Sun, Jul 23, 5:07 PM

View All 18 Files

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T5951: Update qupzilla to falkon (new name and source)

Commits

R2775:b07bfce6ecae: Update of qupzilla to falkon

Summary

Update of qupzilla to falkon 3.0

Resolves T5951

Official blog here

Test Plan

I installed falkon on my system and used it for a while, changing settings etc.

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

Girtablulu created this revision.Mar 9 2018, 10:16 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptMar 9 2018, 10:16 PM

Girtablulu requested review of this revision.Mar 9 2018, 10:16 PM

Needs replaces so it'll automatically replace qupzilla. See https://solus-project.com/articles/packaging/packaging-practices/en/#replace-rename

This revision now requires changes to proceed.Mar 9 2018, 11:08 PM

adding replaces flag to remove qupzilla and install falkon

There is a typo in your commit message qubzilla ?

package.yml
5	Since it is now officially in the KDE project, I guess you'd better pick the source from kde.org rather than github https://download.kde.org/stable/falkon/3.0/src/falkon-3.0.0.tar.xz https://cdn.download.kde.org/stable/falkon/3.0/src/falkon-3.0.0.tar.xz
19	Are you sure these export are still required since the `%cmake` macro already set the LIB_SUFFIX ?

Fixed commit mistake
added replaces flag
removed export commands

In D2479#38184, @Girtablulu wrote:

Fixed commit mistake

added replaces flag

removed export commands

Still qubzilla iso qupzilla

fix typo of qupzilla inside the package.yml

Girtablulu retitled this revision from Update of qubzilla to falkon to Update of qupzilla to falkon.Mar 10 2018, 8:10 PM

Girtablulu edited the summary of this revision. (Show Details)

Girtablulu edited the summary of this revision. (Show Details)Mar 13 2018, 3:29 PM

Girtablulu added a task: T5951: Update qupzilla to falkon (new name and source).

Girtablulu edited the summary of this revision. (Show Details)Mar 13 2018, 10:45 PM

LGTM, I'll coordinate with @ikey on a replaces. Not marking as accepted until I making an SC repo_data PR though.

Nevermind @sunnyflunk already did a PR via https://github.com/solus-project/solus-sc/pull/189

JoshStrobl accepted this revision.Mar 15 2018, 7:28 PM

This revision is now accepted and ready to land.Mar 15 2018, 7:28 PM

Closed by commit R2775:b07bfce6ecae: Update of qupzilla to falkon (authored by Girtablulu, committed by JoshStrobl). · Explain WhyMar 15 2018, 7:40 PM

This revision was automatically updated to reflect the committed changes.

Girtablulu mentioned this in D5860: Rename razer-drivers to openrazer.Mar 29 2019, 9:11 AM

Revision Contents
Changeset List

Path

Size

7305 lines

1 line

17 lines

pspec_x86_64.xml

82 lines

Diff 5994

abi_symbols

Loading...

abi_used_libs

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...