Page MenuHomeSolus

Update of qupzilla to falkon
ClosedPublic

Authored by Girtablulu on Mar 9 2018, 10:16 PM.

Details

Summary

Update of qupzilla to falkon 3.0

Resolves T5951

Official blog here

Test Plan

I installed falkon on my system and used it for a while, changing settings etc.

Diff Detail

Repository
R2775 falkon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Girtablulu created this revision.Mar 9 2018, 10:16 PM
Girtablulu requested review of this revision.Mar 9 2018, 10:16 PM
JoshStrobl requested changes to this revision.Mar 9 2018, 11:08 PM
JoshStrobl added a subscriber: JoshStrobl.

Needs replaces so it'll automatically replace qupzilla. See https://solus-project.com/articles/packaging/packaging-practices/en/#replace-rename

This revision now requires changes to proceed.Mar 9 2018, 11:08 PM
Girtablulu updated this revision to Diff 5995.Mar 9 2018, 11:58 PM
  • adding replaces flag to remove qupzilla and install falkon

There is a typo in your commit message qubzilla ?

package.yml
5

Since it is now officially in the KDE project, I guess you'd better pick the source from kde.org rather than github

20–21

Are you sure these export are still required since the %cmake macro already set the LIB_SUFFIX ?

Girtablulu updated this revision to Diff 6011.Mar 10 2018, 3:24 PM
  • Fixed commit mistake
  • added replaces flag
  • removed export commands
  • Fixed commit mistake
  • added replaces flag
  • removed export commands

Still qubzilla iso qupzilla

Girtablulu updated this revision to Diff 6017.Mar 10 2018, 5:41 PM

fix typo of qupzilla inside the package.yml

Girtablulu retitled this revision from Update of qubzilla to falkon to Update of qupzilla to falkon.Mar 10 2018, 8:10 PM
Girtablulu edited the summary of this revision. (Show Details)
Girtablulu edited the summary of this revision. (Show Details)Mar 13 2018, 10:45 PM

LGTM, I'll coordinate with @ikey on a replaces. Not marking as accepted until I making an SC repo_data PR though.

JoshStrobl accepted this revision.Mar 15 2018, 7:28 PM
This revision is now accepted and ready to land.Mar 15 2018, 7:28 PM
This revision was automatically updated to reflect the committed changes.