Details
- Reviewers
JoshStrobl - Group Reviewers
Triage Team - Maniphest Tasks
- T372: Add Nylas mail client for power users
T2785: Nylas missing library
T3255: Update and rename Nylas N1 to Nylas-Mail
T3262: The new nylas mail client
I've installed this eopkg, ran it, and connected it to my account.
Diff Detail
- Repository
- R2129 n1
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
This needs to be rebased off the existing package, with the release appropriately incremented, regardless of a rename and replace: https://dev.solus-project.com/source/n1/
| package.yml | ||
|---|---|---|
| 11–12 | We're gonna need to coordinate with @ikey on doing the replaces. | |
| 14–38 | You have a bunch of unnecessary builddeps listed. Look at the dependencies / reverse dependencies of the -devel packages. | |
| 46 | This should be an install call, not mkdir. You should be using $installdir too. | |
| 49 | This should be an install call, not mkdir. You should be using $installdir too. | |
| 50 | Should use an absolute path for the symlink. Also use $installdir. | |
| 54 | This should be an install call, not mkdir. You should be using $installdir too. | |
| 55 | Use install, don't copy. And use $installdir. | |
Thanks for taking the time to review the patch.
I believe I've fixed everything you mentioned. Please let me know if there are additional changes needed.
I've moved these changes to be off of the n1 repository.
| pspec_x86_64.xml | ||
|---|---|---|
| 37 | /usr/share/nylas-mail/locales and /usr/share/nylas-mail/resources both still exist in the created eopkg, I'm not sure why the files in those directories aren't showing up in the pspec, or if that's a problem. | |
I believe I've fixed everything you mentioned.
I don't recall being pinged so probably not. :P
I talked with @ikey on IRC about this, but wanted to log my thoughts here for people searching for nylas-mail.
While I got the package to install on my machine, connect to my account, and retrieve my email, I wasn't able to send any emails. It looks like there are a lot of bugs like this and upstream has been pretty quiet. There's now talk of a possible fork. The fork got a response from nylas saying they're going to try to be more engaged with people contributing to the project.
I think if we were to merge this now, it would be broken and wouldn't be helpful to anyone wanting to use it. I'd like to hold, wait and see how nylas responds, and possibly look into adding this in the future.