Initial version of protobuf-c
Ref task T3745 (needs protobuf-c to build)
Details
Details
- Reviewers
JoshStrobl Justin - Group Reviewers
Triage Team - Maniphest Tasks
- T3745: purple-hangouts
- Commits
- R3741:604a7081019e: Initial commit of protobuf-c
Built and installed protobuf-c*.eopkg, then built purple-hangouts and confirmed adding a hangouts account works in pidgin.
Diff Detail
Diff Detail
- Repository
- R3741 protobuf-c
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Fixed:
- component to programming.library
- removed %configure step as %autogen takes care of that
- use --disable-static instead of manually removing the static library file
- run libtool --finish %libdir% after install to satisfy the libtool warning about it
| package.yml | ||
|---|---|---|
| 20 | Not really needed. Warnings are just warnings and don't affect the package in this case. | |
| package.yml | ||
|---|---|---|
| 6 | use https://github.com/protobuf-c/protobuf-c/releases/download/v1.2.1/protobuf-c-1.2.1.tar.gz as source so you won't need to use autogen | |
| 15 | autogen is not required. %configure --disable-static is enough (see my above comment) | |
Comment Actions
Although it is not mandatory, I suggest to make this depends on D505 so it won't be necessary to rebuild it once again afterwards.
Comment Actions
Packaging Changes
- remove libtool --finish step
- use better tarball source
- use %configure --disable-static instead of %autogen --disable-static
Depends on D505
Comment Actions
@mfossen version 1.3.0 is available, perhaps it would be good to update this diff
https://github.com/protobuf-c/protobuf-c/releases/tag/v1.3.0
Comment Actions
Update to 1.3.0, add make check
@mfossen I did update your diff because I needed it to test the updated version of the purple-hangouts plugin, I hope you don't mind.
| package.yml | ||
|---|---|---|
| 7 | should be BSD-2-Clause to be SPDX compatible | |