Page MenuHomeSolus

Initial commit of protobuf-c
ClosedPublic

Authored by mfossen on May 29 2017, 4:26 AM.

Details

Summary

Initial version of protobuf-c

Ref task T3745 (needs protobuf-c to build)

Test Plan

Built and installed protobuf-c*.eopkg, then built purple-hangouts and confirmed adding a hangouts account works in pidgin.

Diff Detail

Repository
R3741 protobuf-c
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mfossen created this revision.May 29 2017, 4:26 AM
JoshStrobl requested changes to this revision.Jun 6 2017, 3:16 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
8

Should be programming.library

15–16

%autogen automatically calls %configure.

21

Should be passing --disable-static instead during autogen, assuming protobuf-c will actually disable static libs in that case.

This revision now requires changes to proceed.Jun 6 2017, 3:16 PM
mfossen updated this revision to Diff 891.Jun 18 2017, 6:38 PM
mfossen edited edge metadata.

Fixed:

  • component to programming.library
  • removed %configure step as %autogen takes care of that
  • use --disable-static instead of manually removing the static library file
  • run libtool --finish %libdir% after install to satisfy the libtool warning about it
JoshStrobl requested changes to this revision.Jun 24 2017, 7:07 PM
JoshStrobl added inline comments.
package.yml
20

Not really needed. Warnings are just warnings and don't affect the package in this case.

This revision now requires changes to proceed.Jun 24 2017, 7:07 PM
kyrios123 added inline comments.
package.yml
6
15

autogen is not required. %configure --disable-static is enough (see my above comment)

Although it is not mandatory, I suggest to make this depends on D505 so it won't be necessary to rebuild it once again afterwards.

mfossen updated this revision to Diff 1088.Jun 26 2017, 9:47 PM
mfossen edited edge metadata.

Packaging Changes

  • remove libtool --finish step
  • use better tarball source
  • use %configure --disable-static instead of %autogen --disable-static

Depends on D505

@mfossen version 1.3.0 is available, perhaps it would be good to update this diff
https://github.com/protobuf-c/protobuf-c/releases/tag/v1.3.0

kyrios123 updated this revision to Diff 2046.Sep 2 2017, 11:10 AM
kyrios123 edited the summary of this revision. (Show Details)
kyrios123 added a subscriber: mfossen.

Update to 1.3.0, add make check

@mfossen I did update your diff because I needed it to test the updated version of the purple-hangouts plugin, I hope you don't mind.

joebonrichie added inline comments.
package.yml
7

should be BSD-2-Clause to be SPDX compatible

kyrios123 updated this revision to Diff 2048.Sep 2 2017, 11:40 AM

Fixed license, thanks @joebonrichie ! :)

Justin accepted this revision.Sep 22 2017, 1:47 AM
This revision was automatically updated to reflect the committed changes.