Rebuild amule against wxwidgets2.8 series
ClosedPublic
Actions

Authored by euoar on May 28 2017, 3:43 PM.

Details

Reviewers

ikey

Maniphest Tasks

T1802: High CPU and RAM usage for aMule

Commits

R355:6abd69228eb1: Rebuild amule against wxwidgets2.8 series

Summary

This fixes T1802. See T1802 for more details.
Amule is for many users unusable because of a bug affecting memory use.
Building it against wxwidgets2.8 solves the problem with no detected side effects.
Both wxwidgets series are supported by the amule project.

Test Plan

I built and installed the package
Sent it for testing to two users affected by the memory bug
After more than 14 hours, amule keeps running without issues

Diff Detail

Repository

R355 amule

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

euoar created this revision.May 28 2017, 3:43 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptMay 28 2017, 3:43 PM

euoar mentioned this in T1802: High CPU and RAM usage for aMule.May 28 2017, 3:44 PM

ikey edited reviewers, added: ikey; removed: Triage Team.May 28 2017, 6:54 PM

Only a minor change to make :D

package.yml
17	Please convert this to: `%autogen --with-wx-config=wx-config-2.8`

This revision now requires changes to proceed.May 28 2017, 7:00 PM

euoar added inline comments.May 28 2017, 7:23 PM

package.yml
17	Hi Ikey :). Tried that before, but it wouldn't build, as then the option --with-wx-config=wx-config-2.8 doesn't get passed to configure, failing to compile.

LGTM.

This revision is now accepted and ready to land.May 28 2017, 7:45 PM

Closed by commit R355:6abd69228eb1: Rebuild amule against wxwidgets2.8 series (authored by euoar, committed by ikey). · Explain WhyMay 28 2017, 7:45 PM

This revision was automatically updated to reflect the committed changes.

ikey mentioned this in R355:e9c520ffba46: Switch Amule to the correct autogen macro per D242.May 28 2017, 7:48 PM

The reason I said to switch the autogen and didn't ask is because I'd already tested it and knew it to work :P R355:e9c520ffba46e7220f1a8cbffa483e6a6ad5c293