Page MenuHomeSolus

Initial Kotlin build. Inclusion of Kotlin fixes T5345.
ClosedPublic

Authored by serebit on Mar 3 2018, 3:15 PM.
Tags
None
Referenced Files
F10983437: D2427.diff
Sun, Jul 23, 2:21 PM
F10983335: D2427.diff
Sun, Jul 23, 1:56 PM
F10944630: D2427.id.diff
Sat, Jul 15, 12:36 AM
F10843414: D2427.id6057.diff
Jun 10 2023, 5:48 PM
F10841793: D2427.id6516.diff
Jun 10 2023, 8:53 AM
F10841788: D2427.id6061.diff
Jun 10 2023, 8:52 AM
F10840090: D2427.id5867.diff
Jun 9 2023, 11:58 PM
F10826600: D2427.diff
Jun 4 2023, 3:14 AM
Tokens
"Grey Medal" token, awarded by Snuggle.

Diff Detail

Repository
R4102 kotlin
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

serebit retitled this revision from Initial build. Inclusion of kotlin fixes T5345. to Initial Kotlin build. Inclusion of Kotlin fixes T5345..Mar 3 2018, 3:19 PM

Also important to note that Kotlin is also packaged in snap form by JetBrains themselves

This revision is now accepted and ready to land.Mar 11 2018, 2:58 PM

Missing Makefile guessing I should also be seeing abi_* reports. Did you actually use solbuild for this?

This revision now requires changes to proceed.Mar 11 2018, 3:30 PM

Added the Makefile. I did use solbuild, I didn't realize I needed to include the makefile as well as the pspec and the package.yml.

Were there no abi_ files? Those need to be included too.

Were there no abi_ files? Those need to be included too.

Nope, no abi_ files were in the directory after a successful make run.

Removed apache-ant from runtime dependencies.

Were there no abi_ files? Those need to be included too.

Kotlin doesn't provide Linux libraries, just like https://dev.solus-project.com/source/apache-ant/

This revision is now accepted and ready to land.Mar 17 2018, 1:44 PM
$ kotlin -version
error: no build.txt was found at home=/usr/share/kotlin

Needs to be fixed. It'll either break tools or anger users. Thanks!

This revision now requires changes to proceed.Mar 25 2018, 4:32 PM

Kotlin was recently updated to 1.2.31, should I fix the missing build.txt in a new package request for 1.2.31 or just fix it in this one?

Might as well update to the newer version, if you don't mind. Same us the update post merge. If that Package Request is behind the current version that's no big deal. The build.txt file definitely needs to go in though. Thanks!

You got it! Fixing it now. I'll modify the diff once I get it working.

Added build.txt to /usr/share/kotlin target, and updated to Kotlin 1.2.31.

LGTM. Thanks! I'll land this when the builder is freed up.

This revision is now accepted and ready to land.Mar 25 2018, 8:20 PM
This revision was automatically updated to reflect the committed changes.