Page MenuHomeSolus

Initial Kotlin build. Inclusion of Kotlin fixes T5345.
ClosedPublic

Authored by serebit on Mar 3 2018, 3:15 PM.

Diff Detail

Repository
R4102 kotlin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

serebit created this revision.Mar 3 2018, 3:15 PM
serebit requested review of this revision.Mar 3 2018, 3:15 PM
serebit retitled this revision from Initial build. Inclusion of kotlin fixes T5345. to Initial Kotlin build. Inclusion of Kotlin fixes T5345..Mar 3 2018, 3:19 PM
Nojpg added a subscriber: Nojpg.Mar 4 2018, 3:47 AM

Also important to note that Kotlin is also packaged in snap form by JetBrains themselves

DataDrake accepted this revision.Mar 11 2018, 2:58 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Mar 11 2018, 2:58 PM
DataDrake requested changes to this revision.Mar 11 2018, 3:30 PM

Missing Makefile guessing I should also be seeing abi_* reports. Did you actually use solbuild for this?

This revision now requires changes to proceed.Mar 11 2018, 3:30 PM
serebit updated this revision to Diff 6057.EditedMar 11 2018, 5:03 PM

Added the Makefile. I did use solbuild, I didn't realize I needed to include the makefile as well as the pspec and the package.yml.

Snuggle added a subscriber: Snuggle.
DataDrake added a comment.EditedMar 11 2018, 6:44 PM

Were there no abi_ files? Those need to be included too.

Were there no abi_ files? Those need to be included too.

Nope, no abi_ files were in the directory after a successful make run.

serebit updated this revision to Diff 6061.Mar 11 2018, 7:55 PM

Removed apache-ant from runtime dependencies.

Were there no abi_ files? Those need to be included too.

Kotlin doesn't provide Linux libraries, just like https://dev.solus-project.com/source/apache-ant/

DataDrake accepted this revision.Mar 17 2018, 1:44 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Mar 17 2018, 1:44 PM
DataDrake requested changes to this revision.Mar 25 2018, 4:32 PM
$ kotlin -version
error: no build.txt was found at home=/usr/share/kotlin

Needs to be fixed. It'll either break tools or anger users. Thanks!

This revision now requires changes to proceed.Mar 25 2018, 4:32 PM

Kotlin was recently updated to 1.2.31, should I fix the missing build.txt in a new package request for 1.2.31 or just fix it in this one?

Might as well update to the newer version, if you don't mind. Same us the update post merge. If that Package Request is behind the current version that's no big deal. The build.txt file definitely needs to go in though. Thanks!

serebit added a comment.EditedMar 25 2018, 4:45 PM

You got it! Fixing it now. I'll modify the diff once I get it working.

serebit updated this revision to Diff 6501.EditedMar 25 2018, 5:49 PM

Added build.txt to /usr/share/kotlin target, and updated to Kotlin 1.2.31.

DataDrake accepted this revision.Mar 25 2018, 8:20 PM

LGTM. Thanks! I'll land this when the builder is freed up.

This revision is now accepted and ready to land.Mar 25 2018, 8:20 PM
This revision was automatically updated to reflect the committed changes.