Page MenuHomeSolus

Initial release of Spice-up
ClosedPublic

Authored by stigarn on Feb 25 2018, 9:55 AM.

Details

Summary

Initial release of Spice-up. Resolves T4845.

Test Plan

Created an presentation and played it.

Diff Detail

Repository
R4115 spice-up
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

stigarn created this revision.Feb 25 2018, 9:55 AM
stigarn requested review of this revision.Feb 25 2018, 9:55 AM
stigarn edited the summary of this revision. (Show Details)Feb 25 2018, 9:56 AM
stigarn added a task: T4845: Spice Up.
DataDrake accepted this revision.Mar 11 2018, 3:03 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Mar 11 2018, 3:03 PM
DataDrake requested changes to this revision.Mar 12 2018, 1:33 AM
DataDrake added inline comments.
package.yml
2

Minor thing, but this should be lowercase

This revision now requires changes to proceed.Mar 12 2018, 1:33 AM
stigarn updated this revision to Diff 6114.Mar 13 2018, 8:11 AM

Fix typo.

DataDrake requested changes to this revision.Mar 17 2018, 1:45 PM

You shouldn't be including the .eopkg file

This revision now requires changes to proceed.Mar 17 2018, 1:45 PM
stigarn updated this revision to Diff 6252.Mar 18 2018, 6:38 AM

Remove eopkg.

DataDrake accepted this revision.Mar 18 2018, 2:48 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Mar 18 2018, 2:48 PM
This revision was automatically updated to reflect the committed changes.