Update snes9x-gtk to 1.55
ClosedPublic
Actions

Authored by Tick on Feb 25 2018, 2:05 AM.

Details

Reviewers

joebonrichie

Group Reviewers

Triage Team

Commits

R2920:913fbd1fe851: Update snes9x-gtk to 1.55

Summary

Added support for new devices.
Improved BS-X memory mapping accuracy.
Fixed APU error causing issues with some games.
Added option to ignore patch checksums.
Fixed build warnings / undefined behavior.
Correct pixel placement in hires.
Fixed RAM mapping for Light Fantasy.
Added Circuit USA APU timing hack.
libretro: Merged some changes from downstream repository.
GTK+: Allow use of XDG config directory.
GTK+: Add 10th save slot.
GTK+: Updated Spanish translation.

Full changelog : https://github.com/snes9xgit/snes9x/releases

Test Plan

I played a few games without any problems.

Diff Detail

Repository

R2920 snes9x-gtk

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Tick created this revision.Feb 25 2018, 2:05 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptFeb 25 2018, 2:05 AM

Tick requested review of this revision.Feb 25 2018, 2:05 AM

joebonrichie requested changes to this revision.Feb 25 2018, 4:27 PM

joebonrichie added a subscriber: joebonrichie.

joebonrichie added inline comments.

package.yml
13	Once again, since you are here can you replace the description with the following paragraph from their website to make it more descriptive. We prefer not to have identical summaries and descriptions. Snes9x is a portable, freeware Super Nintendo Entertainment System (SNES) emulator. It basically allows you to play most games designed for the SNES and Super Famicom Nintendo game systems on your PC or Workstation; which includes some real gems that were only ever released in Japan.
22	`sdl1-image-devel` (pkgconfig(SDL_image)) depends on `sdl1-devel` (pkgconfig(sdl))` so this builddep shouldn't be necessary.
26–27	Clang is default off, you can probably remove this.
27	Should be `pkgconfig(minizip)` (in alphabetical order)
33–37	Since you are here updating the package, can you replace these with octal permissions .e.g `-Dm00644, -Dm00755`