Page MenuHomeSolus

docker: set correct Client version
ClosedPublic

Authored by mati865 on Feb 20 2018, 6:30 PM.

Details

Summary

Fixes T5340

Test Plan

Check if docker version prints correct version instead of unknown-version.

Diff Detail

Repository
R649 docker
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mati865 created this revision.Feb 20 2018, 6:30 PM
mati865 requested review of this revision.Feb 20 2018, 6:30 PM

Should I upgrade package to latest stable or edge release altogether?
https://docs.docker.com/release-notes/docker-ce/

Ping, I guess.

sunnyflunk accepted this revision.Jul 2 2018, 1:30 AM
sunnyflunk added a subscriber: sunnyflunk.

@mati865 I'm going to push this now (to insure that this fix is included). If you are wanting to update and test the full stack, runc, containerd, docker (not sure if there's any others), I'll be happy to merge, I just don't understand docker in any way, shape or form xD

This revision is now accepted and ready to land.Jul 2 2018, 1:30 AM
This revision was automatically updated to reflect the committed changes.

I already did some updates with D2994, D2995, D2996, D2997, D2998 and D2999 but wasn't able to do some deep testing. Maybe someone wants to continue.

@sunnyflunk I only have some experience with docker.
containerd? I think I've heard this name before.
runc? Didn't know something like that exists.

I guess there is some kind of test-suite available in their build systems but I cannot work on this for now.

@mati865 they are just the dependencies of docker. So their test would be ensuring docker works correctly after updating them all. The latest versions of docker could use them also.