Page MenuHomeSolus

Update fossil to 2.5
ClosedPublic

Authored by kyrios123 on Feb 20 2018, 2:00 PM.
Tags
None
Referenced Files
F11066087: D2340.diff
Fri, Aug 11, 5:42 PM
F11001555: D2340.diff
Sun, Jul 30, 9:17 AM
F10994515: D2340.id5948.diff
Tue, Jul 25, 11:21 PM
F10975690: D2340.id5577.diff
Sat, Jul 22, 6:13 AM
F10975304: D2340.id5576.diff
Sat, Jul 22, 4:32 AM
F10962879: D2340.diff
Wed, Jul 19, 12:36 AM
F10796416: D2340.id5948.diff
May 28 2023, 1:58 AM
F10786391: D2340.id.diff
May 26 2023, 7:47 AM

Details

Summary

Changelog available here

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

Clone a repository and tried a few commands as explained on the quick start guide

Diff Detail

Repository
R835 fossil
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kyrios123 updated this revision to Diff 5577.

remove an empty line from package.yml

JoshStrobl added a subscriber: JoshStrobl.

Better to get changelog from https://www.fossil-scm.org/xfer/doc/trunk/www/changes.wiki

Also nuke the newline at the end of package.yml.

This revision now requires changes to proceed.Mar 3 2018, 10:43 AM
kyrios123 edited the summary of this revision. (Show Details)

Changelog link updated

Just to be clear, I don't think this is what I intended with the blank line comment. What I meant was files should end on a new line

My issue was with files like this (which only really happened in 'release : 1' with some of the old python packages):

Screenshot_20180304_182944.png (133×327 px, 9 KB)

What I would consider to be correct is this:

Screenshot_20180304_182904.png (156×329 px, 8 KB)

This patch seems to add an extra line to make it out to line 22 which wasn't my intention

@kyrios123 please confirm you have read above, there's no need to add additional lines to the bottom of files in 99.9% of cases (almost all of incorrect files were fixed in the python update). Using the tools to update, or make bump will fix the files without having to add it manually.

@kyrios123 please confirm you have read above, there's no need to add additional lines to the bottom of files in 99.9% of cases (almost all of incorrect files were fixed in the python update). Using the tools to update, or make bump will fix the files without having to add it manually.

I confirm I have read your comment but I have already added a blank line at the

@kyrios123 please confirm you have read above, there's no need to add additional lines to the bottom of files in 99.9% of cases (almost all of incorrect files were fixed in the python update). Using the tools to update, or make bump will fix the files without having to add it manually.

Got it, I removed my script that adds a blank line at eof if there isn't one already.
Now I'll have to nuke the many already updated patches awaiting review.

This revision is now accepted and ready to land.Mar 17 2018, 12:56 PM
This revision was automatically updated to reflect the committed changes.