Page MenuHomeSolus

Update cargo to 0.25.0
ClosedPublic

Authored by saintdev on Feb 17 2018, 11:19 PM.

Details

Summary

0.25.0

0.24.0

  • Support for alternative registries
  • Support for uninstallation of multiple packages
  • cargo check now supports checking unit tests
  • Detailed release notes

Fixed bash completion for Cargo

Test Plan

Install/compile ripgrep

Diff Detail

Repository
R492 cargo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

saintdev created this revision.Feb 17 2018, 11:19 PM
saintdev requested review of this revision.Feb 17 2018, 11:19 PM

A few changes that might need explanation in this update.

First, we use the Cargo source bundled in the rustc tar. This is the recommended way to compile Cargo by upstream (see these comments on Cargo PR 4623). This came about because upstream removed the Cargo.lock file from the repo. This causes issues when compiling Cargo, where the versions of dependent crates do not match those used by upstream releases, mostly with tests. Also, upstream has been slow to tag releases on Github for the last couple Cargo releases. Using the source bundled with rustc means Cargo can be updated as soon as there is a new rust release.

Second, tests are disabled at this moment. There are a few issues upstream with the tests failing erroneously. When using the bundled rustc sources there is a test that fails, because it detects the wrong Cargo.toml (Cargo issue #4755/Rust issue #48255). If compiled with the upstream tagged releases a git test fails, because the output is slightly different than expected. This is due to version differences in the newer git2 crate (Cargo issue #4908). Tests will be re-enabled once upstream fixes (one of) these issues.

saintdev updated this revision to Diff 5555.Feb 19 2018, 4:55 AM

Fix Cargo bash completions

saintdev edited the summary of this revision. (Show Details)Feb 19 2018, 4:56 AM
ikey accepted this revision.Feb 21 2018, 10:31 PM
This revision is now accepted and ready to land.Feb 21 2018, 10:31 PM
joebonrichie added inline comments.
package.yml
20

Small fyi this pkgconfig isn't needed as openssl-devel is in the system-devel component so will automatically be installed.

This revision was automatically updated to reflect the committed changes.