Differential D2305

Update to 4.5.0
AbandonedPublic
Actions

Authored by catman1900 on Feb 17 2018, 8:44 AM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Summary

NEW: Added ListenBrainz support
NEW: Discord Rich Presence Integration
NEW: Support for Google Cast Groups (finally)
NEW: If lyrics can't be automatically found there's now a handy button to search for them on Google
NEW: You can now disable disabling hardware acceleration on macOS (kinda enabling I guess)
NEW: For all you hungarians, we now have hungarian language support
NEW: Global hotkey for "I'm feeling lucky"
NEW: Clicking on the volume icons now updates the volume (makes sense right?)
FIX: JSON and Playback API time fields now don't climb to infinity and beyond
FIX: You can now type in an input box and pause your music at the same time, crazy stuff...
FIX: If you're in fullscreen mode and you quit, you won't be left staring into the void
FIX: If for whatever reason you have more than 12 chromecasts you can now scroll the cast device list
FIX: There is now an easy way to remove hotkeys

Test Plan

I've been testing it all night and it seems to be good, compiles without any major updates being made to the package.yml file

Diff Detail

Repository

R1039 google-play-music-desktop-player

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

catman1900 created this revision.Feb 17 2018, 8:44 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptFeb 17 2018, 8:44 AM

You need to clone the existing repo and update it. See https://solus-project.com/articles/packaging/updating-an-existing-package/en/

This revision now requires changes to proceed.Feb 17 2018, 12:15 PM

I thought I did clone it and update it, then it says to submit the package the same way you'd submit a new one.

Should I only include a package.yml and the other required things and leave out things like files/ ?

new revision without extra files

You still didn't rebase it correctly.

This revision now requires changes to proceed.Feb 26 2018, 12:59 PM

catman1900 added a comment.Feb 27 2018, 12:52 AM

This comment was removed by catman1900.

Rebased correctly hopefully

catman1900 retitled this revision from the newest google play music desktop player to google-play-desktop-player: update to 4.5.0.Feb 27 2018, 2:36 AM

catman1900 edited the summary of this revision. (Show Details)

JoshStrobl accepted this revision.Feb 27 2018, 3:36 PM

This comment was removed by JoshStrobl.

This revision is now accepted and ready to land.Feb 27 2018, 3:36 PM

Your patch fails to apply cleanly nor is it actually updated. You need to make sure you have the latest git clone: https://dev.solus-project.com/source/google-play-music-desktop-player/

This revision now requires changes to proceed.Feb 27 2018, 3:38 PM