Page MenuHomeSolus
Differential D2296

Update flatpak-builder to 0.10.9
ClosedPublic
Actions

Authored by kyrios123 on Feb 15 2018, 9:59 PM.
Tags
None
Referenced Files
F11048367: D2296.id.diff
Thu, Aug 10, 4:33 PM
F11048365: D2296.id6879.diff
Thu, Aug 10, 4:33 PM
F11048364: D2296.id6310.diff
Thu, Aug 10, 4:33 PM
F11048363: D2296.id5509.diff
Thu, Aug 10, 4:33 PM
F11048362: D2296.id5561.diff
Thu, Aug 10, 4:33 PM
F11048361: D2296.id6873.diff
Thu, Aug 10, 4:33 PM
F11033988: D2296.diff
Wed, Aug 9, 4:21 PM
F10987258: D2296.id6310.diff
Mon, Jul 24, 5:06 AM
View All 15 Files
Subscribers
JoshStrobl
TingPing

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Commits
R3847:f58c8cd4f3fc: Update flatpak-builder to 0.10.9
Summary
  • Support -y argument, which passes it on to flatpak install, etc
  • Fix build on glibc 2.27
  • Fix build on recent glibc
  • Add support for --socket=fallback-x11
  • Fix assert in --install
  • Fix --disable-updates for git sources
  • When mirroring git repos, use a temporary download dir
  • Support running flatpak-builder inside a flatpak sandbox

Depends on D2295

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

Executed the example from this page

Diff Detail

Repository
R3847 flatpak-builder
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kyrios123 created this revision.Feb 15 2018, 9:59 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptFeb 15 2018, 9:59 PM
kyrios123 updated this revision to Diff 5561.Feb 19 2018, 3:20 PM
kyrios123 retitled this revision from Update flatpak-builder to 0.10.8 to Update flatpak-builder to 0.10.9.
kyrios123 edited the summary of this revision. (Show Details)

Bump to 0.10.9

JoshStrobl accepted this revision.Mar 3 2018, 10:40 AM
JoshStrobl added a subscriber: JoshStrobl.

Accepting for inclusion assuming you nuke your newline at the end of the file.

This revision is now accepted and ready to land.Mar 3 2018, 10:40 AM
kyrios123 updated this revision to Diff 6310.Mar 20 2018, 9:47 PM
  • Update license to SPDX 3.0
kyrios123 mentioned this in D2784: Update to 0.10.9.Apr 24 2018, 6:18 AM
TingPing added a subscriber: TingPing.Apr 24 2018, 2:23 PM

Could you add my rundeps from my verison:

  • ccache
  • elfutils # eu-strip
  • flatpak
  • Source types
  • bzr
  • git
  • unzip
  • rpm
  • cpio
  • patch
package.yml
7

Wrong license.

kyrios123 added inline comments.Apr 24 2018, 3:07 PM
package.yml
7

See comment in D2580

kyrios123 added a comment.EditedApr 25 2018, 11:59 AM
In D2296#43845, @TingPing wrote:

Could you add my rundeps from my verison:

  • ccache
  • elfutils # eu-strip
  • flatpak
  • Source types
  • bzr
  • git
  • unzip
  • rpm
  • cpio
  • patch

There are already rundeps

  • bzr
  • elfutils
  • flatpak
  • git

These are in system.base

  • unzip
  • cpio

So only patch, rpm and ccache are missing from your list.
I am not sure most people will require rpm, so it's probably better to not force it as a mandatory dependency.

TingPing added a comment.Apr 25 2018, 1:47 PM
In D2296#43931, @kyrios123 wrote:

So only patch, rpm and ccache are missing from your list.
I am not sure most people will require rpm, so it's probably better to not force it as a mandatory dependency.

Sounds good, thanks.

kyrios123 updated this revision to Diff 6873.Apr 25 2018, 1:57 PM

Fix: license, add missing rundeps

JoshStrobl accepted this revision.Apr 25 2018, 2:25 PM
Closed by commit R3847:f58c8cd4f3fc: Update flatpak-builder to 0.10.9 (authored by kyrios123). · Explain WhyApr 25 2018, 2:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
7 lines
6 lines

Diff 5509

View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.