There's like half a dozen items and a short paragraph of text. Surely we can just get that added to the summary. Also nuke the newline at the end of the package.yml file.

This revision now requires changes to proceed.Mar 3 2018, 10:39 AM

Ignore newline portion of previous comment as per IRC convo.

JoshStrobl accepted this revision.Mar 17 2018, 1:47 PM

This revision is now accepted and ready to land.Mar 17 2018, 1:47 PM

Actually needs to be rebased.

This revision now requires changes to proceed.Mar 17 2018, 1:48 PM

Rebase
Update license to SPDX 3.0
Nuke blank line at the end of package.yml
Add --disable-document-portal for updating xdg-desktop-portal to 0.10

kyrios123 added a child revision: D2580: Update xdg-desktop-portal to 0.11.Mar 20 2018, 9:57 PM

kyrios123 mentioned this in D2781: Update to 0.10.4.Apr 24 2018, 6:17 AM

TingPing added a subscriber: TingPing.Apr 24 2018, 2:20 PM

TingPing added inline comments.

package.yml
9	Incorrect license.

kyrios123 added inline comments.Apr 24 2018, 3:06 PM

package.yml
9	See comment in D2580

Fix: license

TingPing added inline comments.Apr 25 2018, 1:58 PM

package.yml
31	Just a thought since we don't have optional deps. It would be the best UX to depend upon `xdg-desktop-portal-gtk`. (The kde portal isn't packaged here anyway)

kyrios123 added a subscriber: • sunnyflunk.Apr 25 2018, 2:10 PM

kyrios123 added inline comments.

package.yml
31	I guess @sunnyflunk would not agree since it would force installation of xdg-desktop-portal-gtk on Plasma.

JoshStrobl added inline comments.Apr 25 2018, 2:15 PM

package.yml
31	To build on that, Solus GNOME Edition already has a dep of `xdg-desktop-portal-gtk` for gnome-shell and not entirely certain it'll be necessary for the primary image given the coming flatpak support in the Software Center. Just keep it as is for now.

TingPing added inline comments.Apr 25 2018, 2:20 PM

package.yml
31	I guess @sunnyflunk would not agree since it would force installation of xdg-desktop-portal-gtk on Plasma. Well `xdg-desktop-portal-gtk` is sill wanted on Plasma because Solus doesn't have `xdg-desktop-portal-kde`. Solus GNOME Edition already has a dep of xdg-desktop-portal-gtk for gnome-shell At the very least it should be on the Budgie and MATE editions. Flatpak applications are far less functional without a portal. Worth noting future Snap releases also depend upon these portals. given the coming flatpak support in the Software Center. As in it installs `flatpak` and `xdg-desktop-portal-gtk` at first use? Better than nothing but I think its a good idea to not leave cli users in a bad default state.

JoshStrobl accepted this revision.Apr 25 2018, 2:25 PM

JoshStrobl added inline comments.

package.yml
31	At the very least it should be on the Budgie and MATE editions. I disagree. As explained in my comment, Flatpak support will be coming to the SC, and thus that will be the preferred frontend for acquiring flatpaks. As in it installs flatpak and xdg-desktop-portal-gtk at first use? I don't know yet, this is something that needs to be discussed with Ikey. For now I'm accepting the patch, this package can be updated down the road if necessary.