Page MenuHomeSolus

Enable PGP/MIME and S/MIME support.
ClosedPublic

Authored by hashhsah on Feb 15 2018, 7:26 PM.

Details

Summary

Enable PGP/MIME and S/MIME support.

Test Plan

at the end of the configuration stage, we see the following two yes items:

...
PGP/MIME support:     yes (via GpgME)
S/MIME support:       yes (via GpgME)

Diff Detail

Repository
R937 gmime
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

hashhsah created this revision.Feb 15 2018, 7:26 PM
JoshStrobl requested changes to this revision.Feb 15 2018, 7:31 PM
JoshStrobl added a subscriber: JoshStrobl.

at the end of the configuration stage, we see the following two yes items:

We should have a broader test plan. There any test / example code you can run and provide?

This revision now requires changes to proceed.Feb 15 2018, 7:31 PM

@JoshStrobl I'm using the astroid mail client, which uses gmime. If I don't --enable-crypto in gmime, astroid crashes if you try signing/encrypting your email and spits the following error message:

(astroid:18682): gmime-CRITICAL **: g_mime_multipart_signed_sign: assertion 'GMIME_IS_CRYPTO_CONTEXT (ctx)' failed

googling a bit, i realized that this is caused by crypto not enabled in gmime. After the change, signing/encrypting work fine in astroid.

Since astroid is not accepted in the repo yet, i don't know if i should use this as the test plan.
On the other hand, the reverse-dependence of gmime in solus repo doesn't have a lot of items, and i don't know any of them, so i don't have another test case.

JoshStrobl accepted this revision.Feb 15 2018, 8:38 PM

Fair enough.

This revision is now accepted and ready to land.Feb 15 2018, 8:38 PM
JoshStrobl retitled this revision from add support for crypto (based on gpgme) to Enable PGP/MIME and S/MIME support..Feb 15 2018, 8:39 PM
JoshStrobl edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.