Page MenuHomeSolus

Fixed lightscreen building, runs, added desktop launcher.
ClosedPublic

Authored by ZachBacon on Feb 13 2018, 3:51 PM.

Details

Summary

Inclusion of lightscreen to solus

Test Plan

Works, however desktop file will need to be modified to work. Otherwise it launches from terminal and tray icon does load properly. Will update later with more fixes

Diff Detail

Repository
R3746 lightscreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ZachBacon created this revision.Feb 13 2018, 3:51 PM
JoshStrobl requested changes to this revision.May 19 2018, 2:11 PM
JoshStrobl added a subscriber: JoshStrobl.

A rebuild just to validate it still functions would be nice too :)

package.yml
9

Needs to be updated against SPDX-3.0.

39–41

Should be -Dm00755 so we're ensuring there's no suid and uid bits.

This revision now requires changes to proceed.May 19 2018, 2:11 PM
ZachBacon updated this revision to Diff 7339.May 21 2018, 3:44 AM
  • edited package.yml licenses and install as per Josh
ZachBacon updated this revision to Diff 7340.May 21 2018, 4:00 AM
ZachBacon retitled this revision from Fixed lightscreen building to Fixed lightscreen building, runs, added desktop launcher..
ZachBacon edited the test plan for this revision. (Show Details)
  • edited package.yml licenses and install as per Josh and added desktop launcher and icon
ZachBacon updated this revision to Diff 7391.May 24 2018, 3:56 AM
  • edited package.yml licenses and install as per Josh and added desktop launcher and icon

testing will be done once unstable is more stable

@ZachBacon Unstable is more stable now, you can test it :D

Any update on testing this?

DataDrake abandoned this revision.Oct 20 2018, 3:57 PM
DataDrake added a subscriber: DataDrake.

Closing due to lack of activity in over 30 days.

ZachBacon reclaimed this revision.Oct 20 2018, 4:12 PM
ZachBacon mentioned this in T1566: Lightscreen.

So this does work, however tray icon under budgie panel does not show for some reason, but in other environments like plasma, mate and gnome shell it does without a doubt. Gonna try and investigate it, but there is an in program switch to not use tray icon that users can toggle. But ideally I would like to try and figure this out.
So 3/4 desktop environments it works with the tray icon enabled and shows a visible icon.

JoshStrobl accepted this revision.Dec 11 2018, 4:04 AM
This revision is now accepted and ready to land.Dec 11 2018, 4:04 AM
This revision was automatically updated to reflect the committed changes.