Tags

None

Referenced Files

	F10990759: D2275.id5459.diff
	Mon, Jul 24, 10:11 PM

	F10934261: D2275.id7357.diff
	Wed, Jul 12, 11:19 AM

	F10933024: D2275.diff
	Wed, Jul 12, 4:58 AM

	F10921440: D2275.id7357.diff
	Jul 9 2023, 1:00 PM

	F10921439: D2275.id7338.diff
	Jul 9 2023, 1:00 PM

	F10921437: D2275.id5838.diff
	Jul 9 2023, 1:00 PM

	F10921436: D2275.id5460.diff
	Jul 9 2023, 1:00 PM

	F10917608: D2275.diff
	Jul 8 2023, 6:03 PM

View All 18 Files

Subscribers

JoshStrobl

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Maniphest Tasks

T5146: gmusicbrowser

Commits

R4263:21de12fc40e3: Initial commit of gmusicbrowser

Summary

Inclusion of Gmusicbrowser in the repository.

Depends on D2271, D2273, D2274. Resolves T5146.

Test Plan

Installed and played a few songs.

Diff Detail

Repository

R4263 gmusicbrowser

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fbg13 created this revision.Feb 13 2018, 12:10 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptFeb 13 2018, 12:10 AM

Fixed file permissions.

Fix gstreamer dependency.

DataDrake added a child revision: D2544: Initial commit perl-glib-object-introspection.Mar 24 2018, 2:24 PM

DataDrake removed a child revision: D2544: Initial commit perl-glib-object-introspection.

DataDrake added a parent revision: D2544: Initial commit perl-glib-object-introspection.

JoshStrobl requested changes to this revision.May 19 2018, 2:08 PM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
6	`master.zip` isn't accepted. You need to use the tagged tarballs on the GitHub releases page.
7	Please update to SPDX-3.0 identifiers.
12	Not really necessary.
37–39	Should write a patch and apply it instead of sed, so we know when it fails.

This revision now requires changes to proceed.May 19 2018, 2:08 PM

added patches, fixed source, license and description

LGTM. Nice work!

This revision is now accepted and ready to land.May 21 2018, 6:39 PM

Closed by commit R4263:21de12fc40e3: Initial commit of gmusicbrowser (authored by fbg13, committed by JoshStrobl). · Explain WhyMay 21 2018, 6:41 PM

This revision was automatically updated to reflect the committed changes.

Initial commit of gmusicbrowser
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 7357

Makefile

files/0001-fix-error-with-perl-5.24.patch

files/0002-set-notification-category.patch

package.yml

pspec_x86_64.xml

Initial commit of gmusicbrowserClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 7357

Makefile

files/0001-fix-error-with-perl-5.24.patch

files/0002-set-notification-category.patch

package.yml

pspec_x86_64.xml

Initial commit of gmusicbrowser
ClosedPublic
Actions

Revision Contents
Changeset List