Update yaml-cpp to 0.6.2
ClosedPublic
Actions

Authored by kyrios123 on Feb 5 2018, 10:05 PM.

Details

Reviewers

• sunnyflunk
DataDrake

Group Reviewers

Triage Team

Commits

R3297:9dbdd7694ab2: Update yaml-cpp to 0.6.2

Summary

requires C++11
removes dependency on Boost
bug fixes
performance improvements

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

Enabled unit tests

Diff Detail

Repository

R3297 yaml-cpp

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kyrios123 created this revision.Feb 5 2018, 10:05 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptFeb 5 2018, 10:05 PM

kyrios123 mentioned this in D7: Update boost to 1.65.1.Feb 5 2018, 10:14 PM

There's no way this should include libgmock, libgtest libs or headers (if they exist).

They should only be needed for running the tests.

This revision now requires changes to proceed.Mar 24 2018, 7:17 AM

@sunnyflunk they are shipped within the package.
Since it's just a check dependency and not a build/run dependency, is it really worth adding such dependencies (+ gmock is not in the repo) ?

In D2196#41429, @kyrios123 wrote:

@sunnyflunk they are shipped within the package.
Since it's just a check dependency and not a build/run dependency, is it really worth adding such dependencies (+ gmock is not in the repo) ?

Yes. This shouldn't be shipping gmock in the final package.

This revision now requires changes to proceed.Jun 9 2018, 2:53 PM