Page MenuHomeSolus

Initial commit of pimcommon
ClosedPublic

Authored by euoar on May 26 2017, 2:09 AM.
Tags
None
Referenced Files
F11066623: D218.id517.diff
Fri, Aug 11, 6:25 PM
F11047389: D218.diff
Thu, Aug 10, 3:22 PM
F10996972: D218.id596.diff
Thu, Jul 27, 1:07 AM
F10996971: D218.id564.diff
Thu, Jul 27, 1:07 AM
F10996970: D218.id517.diff
Thu, Jul 27, 1:07 AM
F10996969: D218.id386.diff
Thu, Jul 27, 1:07 AM
F10996968: D218.id.diff
Thu, Jul 27, 1:07 AM
F10991791: D218.diff
Tue, Jul 25, 3:34 AM

Details

Summary

Pimcommon library, used by several KDE PIM applications.
Depends on D216 and D217.

Test Plan
  • I build messagelib and akonadiconsole with this needed library.

Diff Detail

Repository
R3491 pimcommon
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Removing unneeded dependencies.

ikey added inline comments.
pspec_x86_64.xml
28

This seems a bit odd - ^ @sunnyflunk is this something in our defaults causing this? i.e. lack of subdirs. I mean its not insane its just a surprise ^^

@ikey Yes. By default it would put them all in /etc/xdg which I've patched out in extra-cmake-modules to /usr/share/xdg and added support in qt5 to support such a directory. Namespacing it off would break everything xD (unless I made 300 patches for the entire KDE stuff and then it still might not work tbh as they tend to operate in a hybrid: sometimes qt paths, sometimes KDE paths, sometimes per package paths...)

Namespacing it off would break everything xD

Ah sure bollocks to that. If its working now and using stateless XDG that's good enough for me. Cheers :D

sunnyflunk added inline comments.
package.yml
7

It's showing two licenses in the git tree
https://cgit.kde.org/pimcommon.git/tree/ LGPL-2.1 as well

This revision now requires changes to proceed.May 30 2017, 9:11 AM
euoar edited edge metadata.

Fix licenses, adding LGPL-2.1

euoar added inline comments.
package.yml
7

Done, hadn't seen that one. Thanks.

This revision is now accepted and ready to land.May 31 2017, 9:29 AM
This revision was automatically updated to reflect the committed changes.