The package.yml has all the officially required dependencies. However some of them pull each other, if you want to trim it to the minimum list of dependencies, the commented ones below can be removed.

builddeps  :
    - pkgconfig(python3)
    - git
    - nodejs-devel
    # - python-ipykernel
    # - python-ipython_genutils
    # - python-jinja
    # - python-jupyter_client
    # - python-jupyter_core
    - python-nbconvert
    # - python-nbformat
    - python-send2trash
    - python-setuptools
    - python-terminado
    # - python-tornado
    # - python-traitlets
rundeps    :
    # - python-ipykernel
    # - python-ipython_genutils
    # - python-jinja
    # - python-jupyter_client
    # - python-jupyter_core
    - python-nbconvert
    # - python-nbformat
    - python-send2trash
    - python-terminado
    # - python-tornado
    # - python-traitlets

I included them all because the jupyter packages already in Solus do the same. Let me know if it is the right approach.

Hi @rjurga, I'm the original packager of the existing jupyter stuff, I'm glad to see that people are using them! Thanks for taking this on, and for reporting the other problems with the current packages, I'll see what I can do to resolve those. Anyway, I have a couple of comments regarding this diff:

• The rundeps are not required as builddeps.
• python-setuptools is not in the correct place to conform to alphabetical order (pkgconfig deps in order, then explicit deps in order).

This should be all you need:

builddeps  :
    - pkgconfig(python3)
    - git
    - nodejs-devel
    - python-setuptools

Also, you are quite correct that the rundeps can be tidied up as they pull each other in as deps. However, personally, I almost always list what is in the setup.py to make absolutely sure that nothing is missed. The Triage Team, however, may have a different view and ask you to tidy it up.

How can we request review for this task?

In D2182#38592, @xulongwu4 wrote:

How can we request review for this task?

It's already in </> Needs Review state. Just look below the task title.

Thanks. I was just hoping it could be reviewed sooner rather than later.

I am currently on a tight schedule (finishing my PhD) and I will only be available from mid-april to work on this again. If someone wants to take over in the meantime feel free, otherwise I'll only get back to it after I'm done with the PhD.

@rjurga No problem, good luck with your thesis, I can take this over tonight after work if no one has any objections.

@sunnyflunk I cannot find a 5.4.1 release or information on any current security issues. Could you point me in the right direction please?

http://seclists.org/oss-sec/2018/q1/238

It appears that it isn't released (I thought it meant that 5.5 was pending release). There's not a lot of information there to patch the fix

Patch is merged and now 5.4.1 is released, so this can be updated now.