Page MenuHomeSolus

Initial inclusion of python-terminado
ClosedPublic

Authored by rjurga on Feb 4 2018, 9:22 AM.

Details

Summary

Initial inclusion of python-terminado, it is required for T5049

Test Plan

nosetests terminado

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

rjurga created this revision.Feb 4 2018, 9:22 AM
rjurga added a comment.Feb 4 2018, 9:24 AM

Please note that I used the tarball from the Python Package Index, not from GitHub. The releases at GitHub don't have a setup.py file, but rather a project.toml file, which I don't know how to handle with the available Python macros.

EP01 added a subscriber: EP01.Feb 4 2018, 11:07 AM

Same as D2182, the rundeps are not required a builddeps.

builddeps  :
    - pkgconfig(python3)
    - python-setuptools

For future reference, when packaging python stuff, the variable install_requires of the setup.py shows the rundeps (which I'm sure you know), but if the package requires any python builddeps they should be in a variable called setup_requires (when using setuptools at least), and then there's the tests_require deps which are needed as builddeps only if you're including unit testing in your package.yml. See here for lots of useful info!

rjurga updated this revision to Diff 5237.Feb 4 2018, 11:28 AM

Remove unnecessary builddeps that are only rundeps.

Thanks for the useful explanation, @EP01 !

DataDrake accepted this revision.Mar 24 2018, 3:51 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Mar 24 2018, 3:51 PM
This revision was automatically updated to reflect the committed changes.