Page MenuHomeSolus

Initial inclusion of python-terminado

Authored by rjurga on Feb 4 2018, 9:22 AM.
Referenced Files
F10818475: D2181.diff
Thu, Jun 1, 1:17 PM
F10800061: D2181.id5237.diff
Sun, May 28, 5:41 PM
F10800010: D2181.id5235.diff
Sun, May 28, 5:25 PM
F10799664: D2181.id6431.diff
Sun, May 28, 3:44 PM
F10798775: D2181.diff
Sun, May 28, 10:49 AM
Fri, May 26, 3:54 AM
F10774369: D2181.id6431.diff
Mon, May 22, 5:51 AM
F10764591: D2181.id5237.diff
Fri, May 19, 8:07 AM



Initial inclusion of python-terminado, it is required for T5049

Test Plan

nosetests terminado

Diff Detail

R4186 python-terminado
Lint Not Applicable
Tests Not Applicable

Event Timeline

Please note that I used the tarball from the Python Package Index, not from GitHub. The releases at GitHub don't have a file, but rather a project.toml file, which I don't know how to handle with the available Python macros.

Same as D2182, the rundeps are not required a builddeps.

builddeps  :
    - pkgconfig(python3)
    - python-setuptools

For future reference, when packaging python stuff, the variable install_requires of the shows the rundeps (which I'm sure you know), but if the package requires any python builddeps they should be in a variable called setup_requires (when using setuptools at least), and then there's the tests_require deps which are needed as builddeps only if you're including unit testing in your package.yml. See here for lots of useful info!

Remove unnecessary builddeps that are only rundeps.

Thanks for the useful explanation, @EP01 !

This revision is now accepted and ready to land.Mar 24 2018, 3:51 PM
This revision was automatically updated to reflect the committed changes.