Page MenuHomeSolus

Updated to version 1.2.8.
ClosedPublic

Authored by sankasan on Jan 31 2018, 7:37 AM.

Details

Summary

Updated to version 1.2.8.

Test Plan
  1. Get access to a VPN setup that uses FortiVPNSSL.
  2. Connect to that VPN.
  3. Try to access some resources on that network (e.g. smb network shares or a RDP server) and verify it can connect.
  4. Disconnect
  5. Try again to connect to these network connectioins and see it fail.

Diff Detail

Repository
R3699 network-manager-fortisslvpn
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sankasan created this revision.Jan 31 2018, 7:37 AM
sankasan added a comment.EditedJan 31 2018, 7:44 AM

Ah fuck it... same issue as before.
Unclear how to resolve this. Steps I did to get to here.

  • git clone https://dev.solus-project.com/source/network-manager-fortisslvpn.git
  • cd network-manager-fortisslvpn/
  • yupdate 1.2.8 https://download.gnome.org/sources/NetworkManager-fortisslvpn/1.2/NetworkManager-fortisslvpn-1.2.8.tar.xz
  • git diff (see the rel 6 to rel 7 in the diff)
  • vim package.yml (change the setup step from %autogen to %configure)
  • make
  • sudo eopkg it network-manager-fortisslvpn-1.2.8-7-1-x86_64.eopkg (and do the tests)
  • git diff (see package.yml and pspec_x86_64.xml marked red)
  • git add package.yml pspec_x86_64.xml
  • git commit --amend
  • arc diff

Resolved it by doing

  • git pull (don't know why this isn't the latest after a clone)
  • git merge (which fails because of conflicts)
  • meld package.yml (remove diff syntax)
  • meld pspec_x86_64.xml (remove diff syntax)
  • git add package.yml pspec_x86_64.xml
  • git commit (git commit --amend doesn't work in this case)
  • arc diff

euuuh you should review your summary ?

sankasan edited the summary of this revision. (Show Details)Jan 31 2018, 11:56 AM

euuuh you should review your summary ?

Thanks :)

sankasan edited the test plan for this revision. (Show Details)Feb 1 2018, 7:30 AM

Can we get this in the next update round?

This comment was removed by JoshStrobl.
sankasan rescinded a token.

@JoshStrobl , what needs to happen to get this in next Fridays update? I'm probably the only user but the previous version is simply broken and either requires the fix I proposed, or this update.

DataDrake accepted this revision.Mar 12 2018, 2:23 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Mar 12 2018, 2:23 AM
This revision was automatically updated to reflect the committed changes.