Page MenuHomeSolus

Initial inclusion of python-seaborn, fixes T5655
ClosedPublic

Authored by rjurga on Jan 30 2018, 10:26 PM.
Tags
None
Referenced Files
F11068577: D2152.id5240.diff
Fri, Aug 11, 9:58 PM
F11054793: D2152.id5143.diff
Fri, Aug 11, 1:11 AM
F11054792: D2152.id5148.diff
Fri, Aug 11, 1:11 AM
F11054791: D2152.id6434.diff
Fri, Aug 11, 1:11 AM
F11054790: D2152.id.diff
Fri, Aug 11, 1:11 AM
F11054789: D2152.id5144.diff
Fri, Aug 11, 1:11 AM
F11054788: D2152.id5240.diff
Fri, Aug 11, 1:11 AM
F11054787: D2152.id5145.diff
Fri, Aug 11, 1:11 AM
Subscribers

Details

Summary

Initial inclusion of python-seaborn, fixes T5655

Test Plan

Tests can be run with nosetests --with-doctest seaborn.
It fails 2 tests for this version, whether from the build or directly
from tarball. Works properly in normal usage, such as following examples
from the website's gallery.

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rjurga edited the summary of this revision. (Show Details)

Initial inclusion of python-seaborn, for T5655

rjurga retitled this revision from Initial inclusion of python-seaborn, for T5655 to Initial inclusion of python-seaborn, fixes T5655.
rjurga edited the summary of this revision. (Show Details)

Use fixes keyword

Added scipy, matplotlib and pandas as build deps.
It seems to work fine without, but I just noticed this comment in
setup.py: `Just make sure dependencies exist, I haven't rigorously
tested what the minimal versions that will work are`. So better to
take no risk I believe.

Remove unnecessary builddeps that are only rundeps. The comment I refer to in
the previous revision actually is for rundeps, so all was fine already.

This revision is now accepted and ready to land.Mar 24 2018, 4:02 PM
This revision was automatically updated to reflect the committed changes.