Paths

Table of Contentst

Differential D2132

Initial inclusion of go-ipfs
ClosedPublic
Actions

Authored by taaem on Jan 29 2018, 5:39 PM.

Tags

None

Referenced Files

	F11052984: D2132.id.diff
	Thu, Aug 10, 10:22 PM

	F11052983: D2132.id9161.diff
	Thu, Aug 10, 10:22 PM

	F11052982: D2132.id9185.diff
	Thu, Aug 10, 10:22 PM

	F11052981: D2132.id5122.diff
	Thu, Aug 10, 10:22 PM

	F11037521: D2132.diff
	Wed, Aug 9, 8:47 PM

	F11015384: D2132.diff
	Sat, Aug 5, 10:55 AM

	F10876253: D2132.diff
	Jun 20 2023, 9:54 AM

	F10844714: D2132.id9185.diff
	Jun 10 2023, 9:47 PM

View All 11 Files

Subscribers

Tokens

"Heartbreak" token, awarded by Snuggle.

Details

Reviewers

JoshStrobl
DataDrake

Group Reviewers

Maniphest Tasks

Commits

R4474:7aa060c19193: Initial inclusion of go-ipfs

Summary

Initial Inclusion of go-ipfs into the main repo. Resolves T5361.

Test Plan

Run ipfs init.
Then run ipfs daemon, then stopping the daemon again and running systemctl --user start ipfs.service, which also starts the daemon.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

taaem created this revision.Jan 29 2018, 5:39 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJan 29 2018, 5:39 PM

taaem added a task: T5361: IPFS.Jan 29 2018, 5:40 PM

Additionally, please validate the systemd service and update the test plan accordingly.

package.yml
8	`network.base` is installed on everyone's system, meaning this would be installed automatically (which ya know, isn't good). Should be changed to `network.util` or `network.clients`
33–35	None of this is needed. We indicate the license in the SC and eopkg. We don't need the README. Changelogs are done via package updates and indicated in SC.

This revision now requires changes to proceed.Mar 3 2018, 10:26 AM

JoshStrobl retitled this revision from Initial Inclusion, T5361 to Initial inclusion of go-ipfs.Mar 3 2018, 10:27 AM

JoshStrobl edited the summary of this revision. (Show Details)

Abandoning due to lack of movement in over 30 days. Please feel free to re-open after addressing the issues previously raised.

@taaem, I am so sorry. I misread a date and closed this stupidly.

Please re-submit by running a arc diff --update D2132 after you make the changes.

Sorry again :(

Snuggle awarded a token.Mar 16 2018, 7:18 PM

Update the component and don't install unnecessary files

taaem edited the test plan for this revision. (Show Details)Aug 25 2018, 5:06 PM

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Aug 25 2018, 8:30 PM

Closed by commit R4474:7aa060c19193: Initial inclusion of go-ipfs (authored by taaem, committed by DataDrake). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

1 line

3 lines

files/

9 lines

31 lines

pspec_x86_64.xml

40 lines

Diff 9185

Makefile

Loading...

abi_used_libs

Loading...

files/ipfs.service

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...